Cannot build when the current kernel has no source installed

[Carthik Sharma]

Originally filed using reportbug. Filing by proxy.

From: Matthias Urlichs <email address hidden>
To: Ubuntu Bug Tracking System <email address hidden>
Subject: module-assistant: Cannot build when the current kernel has no source installed
X-Mailer: reportbug 3.18ubuntu1
Date: Fri, 04 Aug 2006 20:00:37 +0200

Package: module-assistant
Version: 0.10.6
Severity: important
Tags: patch

In the LOOKUP loop, IMHO the source lookup should be by $kvers (the
actual loop index!) and not $my_kvers.

The problem this patch solves is that I cannot build anything for *any*
kernel if I don't have the kernel headers for the *current* kernel
installed. I rather doubt that that's what you intend to happen...

diff -rub module-assistant-0.10.6.orig/debian/changelog
module-assistant-0.10.7/debian/changelog
--- module-assistant-0.10.6.orig/debian/changelog 2006-07-23 17:48:10.000000000 +0200
+++ module-assistant-0.10.7/debian/changelog 2006-08-04 19:59:47.000000000 +0200
@@ -1,3 +1,10 @@
+module-assistant (0.10.7) unstable; urgency=low
+
+ * Fixed a bug that prevented building for a different kernel
+ when the *current* kernel's headers/source were not installed.
+
+ -- Matthias Urlichs <email address hidden> Fri, 4 Aug 2006 19:58:51 +0200
+
 module-assistant (0.10.6) unstable; urgency=low

   * no external command reads untill the package is known, avoids
diff -rub module-assistant-0.10.6.orig/module-assistant
module-assistant-0.10.7/module-assistant
--- module-assistant-0.10.6.orig/module-assistant 2006-07-23 17:48:10.000000000 +0200
+++ module-assistant-0.10.7/module-assistant 2006-08-04 19:53:40.000000000 +0200
@@ -1287,8 +1287,8 @@

    HAVEIT: foreach $kvers (@opt_kverslist) {
       next HAVEIT if(defined($kerneldirs{$kvers}));
- my $kheaders=get_kpackage($my_kvers)."-headers";
- LOOKUP: foreach $poskdir ("/lib/modules/".$my_kvers."/build",
"/lib/modules/".$my_kvers."/source", <$opt_userdir/usr_src/*>, "$usrc/linux",
"$usrc/$kheaders-$my_kvers", <$usrc/*>, </usr/local/src/*>) {
+ my $kheaders=get_kpackage($kvers)."-headers";
+ LOOKUP: foreach $poskdir ("/lib/modules/".$kvers."/build",
"/lib/modules/".$kvers."/source", <$opt_userdir/usr_src/*>, "$usrc/linux",
"$usrc/$kheaders-$kvers", <$usrc/*>, </usr/local/src/*>) {
          if(defined($poskdir) && -d $poskdir) {
             if(!-x $poskdir) {
                if(!$opt_quiet) {
-- System Information:
Debian Release: testing/unstable
  APT prefers dapper
  APT policy: (850, 'dapper'), (745, 'edgy'), (500, 'edgy-updates'), (500,
'edgy-security'), (500, 'dapper-updates'), (500, 'dapper-security')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-rc2-1.29
Locale: LANG=en_US.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

Versions of packages module-assistant depends on:
ii libtext-wrapi18n-perl 0.06-4 internationalized substitute of Te
ii perl 5.8.7-10ubuntu1 Larry Wall's Practical Extraction

Versions of packages module-assistant recommends:
ii liblocale-gettext-perl 1.05-1 Using libc functions for internati

-- no debconf information

[Rocco Stanzione (trappist)]

Confirming the bug. Not terribly important, but it would be quite nice and the fix seems to be attached.