scan-cache command is broken

[Michael Ellerman]

concordia ~/src/work/msi$ bzr scan-cache
bzr: ERROR: exceptions.TypeError: __init__() takes at least 3 arguments (2 given)

Traceback (most recent call last):
  File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 697, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 659, in run_bzr
    ret = run(*run_argv)
  File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 281, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/michael/src/bzr/mirrors/trunk/bzrlib/builtins.py", line 1787, in run
    c = HashCache(u'.')
TypeError: __init__() takes at least 3 arguments (2 given)

bzr 0.9.0dev0 on python 2.4.3.final.0 (linux2)
arguments: ['/home/michael/bin/bzr', 'scan-cache']

** please send this report to <email address hidden>

This should probably just try to open a working tree and use it's hashcache object. Obviously there's no test for this either.

[Robert Collins (lifeless)]

On Mon, 2006-08-07 at 06:57 +0000, Michael Ellerman wrote:
> Public bug reported:
>
> concordia ~/src/work/msi$ bzr scan-cache
> bzr: ERROR: exceptions.TypeError: __init__() takes at least 3 arguments (2 given)
>
> Traceback (most recent call last):
> File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 697, in run_bzr_catch_errors
> return run_bzr(argv)
> File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 659, in run_bzr
> ret = run(*run_argv)
> File "/home/michael/src/bzr/mirrors/trunk/bzrlib/commands.py", line 281, in run_argv_aliases
> return self.run(**all_cmd_args)
> File "/home/michael/src/bzr/mirrors/trunk/bzrlib/builtins.py", line 1787, in run
> c = HashCache(u'.')
> TypeError: __init__() takes at least 3 arguments (2 given)
>
> bzr 0.9.0dev0 on python 2.4.3.final.0 (linux2)
> arguments: ['/home/michael/bin/bzr', 'scan-cache']
>
> ** please send this report to <email address hidden>
>
>
> This should probably just try to open a working tree and use it's hashcache object. Obviously there's no test for this either.

Do we need this? Why not delete it?

Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[John A Meinel (jameinel)]

Michael, do you have a specific use for 'scan-cache'? I'm assuming it has something to do with a large tree you have.

But otherwise I agree with Robert that it should just be removed.

[Michael Ellerman (michael-ellerman)]

Not really. I found it while I was trying to debug some spurious stats. It could be useful on large trees now that I think about it, but we should probably just rip it out unless someone has a solid usecase.

Bundle attached.

[Martin Pool (mbp)]

Will review and merge it

[Martin Pool (mbp)]

I'll commit the trivial fix

[Wouter van Heyst (larstiq)]

merged in r2116