Links within Terminator are not able to open

[Marcel Blenkers]

In the Versions prior to 0.91 it was possible to open Links with a right-click and select "open Link".

This is available in the "normal" Gnome-Terminal, but it is not working within terminator any more.

There is the Option to Open the Link, but nothing happens.

I am running:

Terminator Version V0.91
Python: Python 2.6

Thanks in advance

[Chris Jones (cmsj)]

Which distro/desktop are you using?

FWIW we hand off the URL opening in 0.91 to the gtk library, which will very likely be using whatever is set as your preferred browser in GConf (e.g. in GNOME's Preferred Applications preferences editor).

[Marcel Blenkers (marcel-blenkers)]

Hi Chris,

i am running

Fedora 11
Desktop Gnome (Version could be stated as i arrive @home .)

Please note the following:

While i am running the usual ordinary Gnome-Terminal, a link is clickable within the ordinary Gnome-Terminal-Client.
Means Firefox does open the Link.

Only with Terminator this is not possible.

but do i select "Copy Link" this is working! Means, i am able to copy a link within the terminator-Window and paste it into the addressbar of firefox.

Hope that helps..

Greetings

Marcel

[Chris Jones (cmsj)]

Marcel: Interesting, from the sounds of your system I would expect this to work properly. Could you please run "terminator -d" from a terminal, try to open a link inside it and then attach the outputted log to this bug report?

I'm also curious which version of the Python GTK library you have installed. It seems like the URL opening function that 0.91 uses only got added to PyGTK in 2.14.

Thanks very much for your help :)

[Chris Jones (cmsj)]

I've speculatively marked this as FIx Committed because I've added some checks to the code so older versions of PyGTK should fall back to other methods of opening URLs. If you're able to test trunk then I'd love to know if it works now, otherwise it'll be out shortly in 0.92. Thanks again.

[Marcel Blenkers (marcel-blenkers)]

Version 0.92

still not working..

Output terminator -d

..

Window::on_window_state_changed: Window::on_window_state_changed: fullscreen=False, maximised=False
ConfigBase::get_item: ConfigBase::get_item: title_transmit_fg_color found in globals: #ffffffffffff
ConfigBase::get_item: ConfigBase::get_item: title_transmit_bg_color found in globals: #c8c800000303
ConfigBase::get_item: ConfigBase::get_item: title_transmit_fg_color found in globals: #ffffffffffff
ConfigBase::get_item: ConfigBase::get_item: title_transmit_bg_color found in globals: #c8c800000303
ConfigBase::get_item: ConfigBase::get_item: show_titlebar found in profile default: True
ConfigBase::get_item: ConfigBase::get_item: focus found in globals: click
ConfigBase::get_item: ConfigBase::get_item: focus found in globals: click
ConfigBase::load: ConfigBase::load: config already loaded
ConfigBase::get_item: ConfigBase::get_item: active_encodings found in profile default: ['UTF-8', 'ISO-8859-1']
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Already loaded
PluginRegistry::get_plugins_by_capability: PluginRegistry::get_plugins_by_capability: searching 3 plugins for terminal_menu
PluginRegistry::load_plugins: PluginRegistry::load_plugins: Already loaded
PluginRegistry::get_plugins_by_capability: PluginRegistry::get_plugins_by_capability: searching 3 plugins for url_handler
Terminal::open_url: open_url: URL: http://irc-addicts.de (prepared: True)
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/terminatorlib/terminal_popup_menu.py", line 60, in <lambda>
    item.connect('activate', lambda x: terminal.open_url(url, True))
  File "/usr/lib/python2.6/site-packages/terminatorlib/terminal.py", line 1177, in open_url
    gtk.show_uri(None, url, gtk.gdk.CURRENT_TIME)
AttributeError: 'module' object has no attribute 'CURRENT_TIME'
ConfigBase::get_item: ConfigBase::get_item: title_transmit_fg_color found in globals: #ffffffffffff
ConfigBase::get_item: ConfigBase::get_item: title_transmit_bg_color found in globals: #c8c800000303
ConfigBase::get_item: ConfigBase::get_item: title_transmit_fg_color found in globals: #ffffffffffff
ConfigBase::get_item: ConfigBase::get_item: title_transmit_bg_color found in globals: #c8c800000303
ConfigBase::get_item: ConfigBase::get_item: show_titlebar found in profile default: True
ConfigBase::get_item: ConfigBase::get_item: focus found in globals: click
ConfigBase::get_item: ConfigBase::get_item: focus found in globals: click

[Chris Jones (cmsj)]

As of trunk r996 I've made the URL handler even more defensive, so it should fallback gracefully with the pygtk version you have.

[Michael Lustfield (michaellustfield)]

I'm still having this issue in 10.04. I'm attaching my debug log as well. It seems to be about the same. I opened terminator, typed a link, hovered right clicked, click Open Link.

[Michael Lustfield (michaellustfield)]

Fore easier reading - this is the relevant part...

Terminal::open_url: open_url: URL: http://google.com (prepared: True)
Traceback (most recent call last):
  File "/usr/share/terminator/terminatorlib/terminal_popup_menu.py", line 60, in <lambda>
    item.connect('activate', lambda x: terminal.open_url(url, True))
  File "/usr/share/terminator/terminatorlib/terminal.py", line 1195, in open_url
    gtk.show_uri(None, url, gtk.gdk.CURRENT_TIME)
gio.Error: Operation not supported

[Chris Jones (cmsj)]

I'm not sure why you're seeing that exception in Lucid, it should work fine, but I've made the URL dispatcher even more defensive so in that situation it will catch the exception and fall back to xdg-open.

[Chris Jones (cmsj)]

(as trunk revision 1050, I meant to say)