Eye and speaker icons in a clip can be marked/unmarked in razor and resize modes and with the right button

[Rodrigo Castelan Carlson]

1) Ubuntu 10.04 beta - Guest OS on Virtual Box with Windows 7
2) Ubuntu Software Manager
3) OpenShot 1.1.1

4) Eye and speaker icons in a clip can be marked/unmarked in razor and resize modes and with the right button.

This is an inconvenient, especially if working with short clips or low zoom. I believe this is not the desired behavior.

[Rodrigo Castelan Carlson (rodrigocarlson)]

Cenwen, I disagree with setting this bug importance as "wishlist", because it describes a incorrect functioning of the software, i.e., if I want to cut the clip I'm not setting the audio or video. Anyway, this is not important.

To fix this it suffices to do the following changes to the class clip (clip.py):

1) Modify the function 'on_visible_click' to:
 def on_visible_click (self, item, target, event):
  # only respond to the first mouse button
  if event.button == 1:
   # determine what cursor mode is enable (arrow, razor, snap, etc...)
   (isArrow, isRazor, isSnap, isResize) = self.parent.parent.project.form.get_toolbar_options()

   # ARROW MODE
   if isArrow:
    # --> EXISTING CODE SHIFTED BY TWO TABS

2) Modify the function 'on_audio_click' to:
 def on_audio_click (self, item, target, event):
  # only respond to the first mouse button
  if event.button == 1:
   # determine what cursor mode is enable (arrow, razor, snap, etc...)
   (isArrow, isRazor, isSnap, isResize) = self.parent.parent.project.form.get_toolbar_options()

   # ARROW MODE
   if isArrow:
    # --> EXISTING CODE SHIFTED BY TWO TABS

While checking this, a related bug was revealed. When using the razor, and only with the razor, if I cut a clip above the video or audio icons, the cursor is reset to arrow (wrong), but stays in the razor mode (correct). This happens because of
  # reset the cursor
  self.parent.parent.project.form.MyCanvas.window.set_cursor(None)
in 'on_button_release_x' function also in the clip class.

Unintentionally the previous suggested fix also solves this bug, though I'm not sure if it really does solve it or simply hides it. Someone more familiar with the code would have to check.

[Olivier Girard (eolinwen)]

Rodrigo, sorry for this mistake.
And thanks for the "patch"!!!!
I 'm going to change it in another tag.
After testing, your modifications will be included in a next version of Openshot.
Thnaks (and yet sorry )