"format sting" errors when compiling awn-0.4.0rc1

Bug #552529 reported by Ahmad Samir
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Awn Extras
Fix Released
High
Michal Hruby

Bug Description

While building awn-0.4.0rc1, I get these errors:
applet.c: In function ‘garbage_applet_show_error_message’:
applet.c:284: error: format not a string literal and no format arguments
applet.c: In function ‘garbage_applet_on_menu_empty_activate’:
applet.c:461: error: format not a string literal and no format arguments
make[4]: *** [applet.lo] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
error: Bad exit status from /home/user/rpm/tmp/rpm-tmp.uor0nC (%build)

I've used the attached patch, and that makes it build OK.

Related branches

Revision history for this message
Ahmad Samir (ahmadsamir) wrote :
Revision history for this message
Ahmad Samir (ahmadsamir) wrote :

Also, initially I tried patching applets/maintained/garbage/applet.c, but it got overwritten; it wasn't until moonbeam pointed out in #awn that the .c files are modified/written by vala at build time; so maybe those .c files shouldn't be in the tarball?

Revision history for this message
Michal Hruby (mhr3) wrote :

Thanks for the patch. The c files are part of the release tarball, so that one doesn't need valac to compile the package (obviously this was broken in RC1).

Changed in awn-extras:
assignee: nobody → Michal Hruby (mhr3)
importance: Undecided → High
milestone: none → 0.4.0
status: New → Fix Committed
Mark Lee (malept)
Changed in awn-extras:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.