mbp-nvidia-bl-dkms 0.24.1-jaunty fails to install on MacbookPro 5,3

[Arnold Liu]

Hi,

I'm trying to install mbp-nvidia-bl-dkms 0.24.1-jaunty on my MacbookPro 5,3.
It looks as if it's referencing a non-existent field in "struct backlight_properties"...

[arnold@arnold-ubuntu-1 ~$ cat /var/lib/dkms/mbp_nvidia_bl/0.24.1/build/make.logDKMS make.log for mbp_nvidia_bl-0.24.1 for kernel 2.6.28-18-generic (i686)
Mon Mar 29 20:55:27 PDT 2010
make: Entering directory `/usr/src/linux-headers-2.6.28-18-generic'
  CC [M] /var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.o
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:34:3: warning: #warning USE_PLATFORM_DRIVER
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c: In function ‘intel_chipset_send_intensity’:
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:63: error: ‘struct backlight_properties’ has no member named ‘state’
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:63: error: ‘BL_CORE_FBBLANK’ undeclared (first use in this function)
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:63: error: (Each undeclared identifier is reported only once
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:63: error: for each function it appears in.)
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:65: error: ‘struct backlight_properties’ has no member named ‘state’
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:65: error: ‘BL_CORE_SUSPENDED’ undeclared (first use in this function)
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c: In function ‘nvidia_chipset_send_intensity’:
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:111: error: ‘struct backlight_properties’ has no member named ‘state’
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:111: error: ‘BL_CORE_FBBLANK’ undeclared (first use in this function)
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:113: error: ‘struct backlight_properties’ has no member named ‘state’
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:113: error: ‘BL_CORE_SUSPENDED’ undeclared (first use in this function)
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c: In function ‘mbp_probe’:
/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.c:392: warning: passing argument 4 of ‘backlight_device_register’ discards qualifiers from pointer target type
make[1]: *** [/var/lib/dkms/mbp_nvidia_bl/0.24.1/build/mbp_nvidia_bl.o] Error 1
make: *** [_module_/var/lib/dkms/mbp_nvidia_bl/0.24.1/build] Error 2
make: Leaving directory `/usr/src/linux-headers-2.6.28-18-generic'
[arnold@arnold-ubuntu-1 ~$

(I had an older version of mbp-nvidia-bl-dkms working before, though...)

[Arnold Liu (asliu23)]

Also, I see the same compile error in nvidia-bl-dkms-0.16.5 too...

[Mario Schwalbe (schwalbe)]

Should both compile again now.

[Arnold Liu (asliu23)]

Thanks Mario - yup, mbp-nvidia-bl-dkms is working for me again.
How do I close this bug?

[Mario Schwalbe (schwalbe)]

@Arnold Liu: I don't know. But something different: Does nvidia_bl work on your machine? Unfortunately, one usually doesn''t get positive feedback if it works...

[Arnold Liu (asliu23)]

Hi Mario,
No - I removed mbp-nvidia-bl and installed nvidia-bl : the install goes through fine now, and I can see that when I hit the brightness buttons that I get a little notification on the top right that it thinks it's changing brightness, but nothing actually happens to the brightness of the screen.

[arnold@arnold-ubuntu-1 Desktop$ sudo dmidecode -s system-product-name
MacBookPro5,3
[arnold@arnold-ubuntu-1 Desktop$ uname -a
Linux arnold-ubuntu-1 2.6.28-18-generic #60-Ubuntu SMP Fri Mar 12 04:40:52 UTC 2010 i686 GNU/Linux

after uninstalling nvidia-bl, then re-installing mbp-nvidia-bl still works fine for me.

[Mario Schwalbe (schwalbe)]

Thanks for trying this. But actually, just pressing the function keys is somewhat too high level. Can you please also try to load the driver and inspect its output in the kernel log? After installation (btw: you can install both but nvidia_bl, if present, takes precedence), just run:

$ sudo rmmod mbp_nvidia_bl
$ sudo rmmod nvidia_bl
$ sudo modprobe nvidia debug=1
$ echo 512 | sudo tee /sys/class/backlight/nvidia_backlight/brightness

Or try some other values. And send me the output or post here. Thanks.

[Arnold Liu (asliu23)]

Hi Mario,
Here's the output in kern.log - there were no changes in the brightness of the screen, though...

Desktop$
[arnold@arnold-ubuntu-1 Desktop$ sudo tail -f /var/log/kern.log
Apr 1 21:01:01 arnold-ubuntu-1 kernel: [ 26.164015] vmnet8: no IPv6 routers present
Apr 1 21:01:01 arnold-ubuntu-1 kernel: [ 26.380049] vmnet1: no IPv6 routers present
Apr 1 21:01:05 arnold-ubuntu-1 kernel: [ 30.052101] eth1: no IPv6 routers present
Apr 1 21:01:21 arnold-ubuntu-1 kernel: [ 45.754316] applesmc: light sensor data length set to 10
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575133] /dev/vmnet: open called by PID 2738 (vmnet-bridge)
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575146] /dev/vmnet: hub 0 does not exist, allocating memory.
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575164] /dev/vmnet: port on hub 0 successfully opened
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575174] bridge-eth1: is a Wireless Adapter
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575178] bridge-eth1: up
Apr 1 21:01:40 arnold-ubuntu-1 kernel: [ 64.575183] bridge-eth1: attached
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261699] nvidia_bl: MacBookPro 5,3 detected
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261730] nvidia_bl: Nvidia graphics adapter 10de:0647 (106b:00bc) detected
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261733] nvidia_bl: using BAR #0 at 0xe4000000, smartdimmer at 0xe461c084
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261911] nvidia_bl: register mask: 0x000003ff
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261914] nvidia_bl: setting brightness to 1023
Apr 1 21:04:39 arnold-ubuntu-1 kernel: [ 244.261916] nvidia_bl: register write: 0x800003ff
Apr 1 21:05:05 arnold-ubuntu-1 kernel: [ 270.233816] nvidia_bl: setting brightness to 512
Apr 1 21:05:05 arnold-ubuntu-1 kernel: [ 270.233820] nvidia_bl: register write: 0x80000200
Apr 1 21:05:17 arnold-ubuntu-1 kernel: [ 282.004325] nvidia_bl: setting brightness to 800
Apr 1 21:05:17 arnold-ubuntu-1 kernel: [ 282.004329] nvidia_bl: register write: 0x80000320
Apr 1 21:05:25 arnold-ubuntu-1 kernel: [ 289.740375] nvidia_bl: setting brightness to 200
Apr 1 21:05:25 arnold-ubuntu-1 kernel: [ 289.740378] nvidia_bl: register write: 0x800000c8

[Mario Schwalbe (schwalbe)]

The output looks perfect. Looks like nvidia_bl doesn't work on the MacBook Pro 5.3. Sadly. But thanks anyway.

[Matteo Dell'Amico (della)]

Mario: same behavior as Arnold, on MBP 5.1.

Apr 24 08:46:08 raker kernel: [53648.168395] nvidia_bl: using BAR #0 at 0xe4000000, smartdimmer at 0xe461c084
Apr 24 08:46:08 raker kernel: [53648.168468] nvidia_bl: register mask: 0x000003ff
Apr 24 08:46:08 raker kernel: [53648.168497] nvidia_bl: register read: 0x0000007f
Apr 24 08:46:08 raker kernel: [53648.168499] nvidia_bl: read brightness of 127
Apr 24 08:46:08 raker kernel: [53648.168502] nvidia_bl: setting brightness to 1023
Apr 24 08:46:08 raker kernel: [53648.168504] nvidia_bl: register write: 0x800003ff
Apr 24 08:46:15 raker kernel: [53655.278055] nvidia_bl: setting brightness to 512
Apr 24 08:46:15 raker kernel: [53655.278059] nvidia_bl: register write: 0x80000200
Apr 24 08:46:30 raker kernel: [53670.168190] nvidia_bl: setting brightness to 23
Apr 24 08:46:30 raker kernel: [53670.168193] nvidia_bl: register write: 0x80000017