scripts/cache-country-mirrors.py breaks across file systems

[Steve McInerney]

launchpad@iron:~$ LPCONFIG=gina /srv/debian-import.launchpad.net/production/launchpad/scripts/cache-country-mirrors.py -q /srv/mirrors.ubuntu.com/www
Traceback (most recent call last):
  File "/srv/debian-import.launchpad.net/production/launchpad/scripts/cache-country-mirrors.py", line 58, in <module>
    CacheCountryMirrors('cache-country-mirrors').lock_and_run()
  File "/srv/debian-import.launchpad.net/production/launchpad-rev-9072/lib/lp/services/scripts/base.py", line 290, in lock_and_run
    implicit_begin=implicit_begin, isolation=isolation)
  File "/srv/debian-import.launchpad.net/production/launchpad-rev-9072/lib/lp/services/scripts/base.py", line 248, in run
    self.main()
  File "/srv/debian-import.launchpad.net/production/launchpad/scripts/cache-country-mirrors.py", line 54, in main
    os.rename(tmpfile, filename)
OSError: [Errno 18] Invalid cross-device link

launchpad@iron:~$ df -h
Filesystem Size Used Avail Use% Mounted on
/dev/cciss/c0d0p1 65G 4.8G 59G 8% /
...
/dev/cciss/c0d1p1 136G 52G 83G 39% /srv

I'm guessing it's writing in /tmp?

[Curtis Hovey (sinzui)]

Has this always been the setup on production? Is the script failing eveytime? Would we need to cherry pick a fix for thie next week?

[Steve McInerney (spm)]

* Has this always been the setup on production?

Not sure I appreciate the question? This is a new service. So, for the server it's been provisioned on, yes.
As for the rest of LP/Prod; it various; some have similar layouts; some don't.
istr it was use of this assumption - one filesystem - that broke the librarian rather spectacularly.

* Is the script failing eveytime?

Yes

* Would we need to cherry pick a fix for thie next week?

It's in reference to RT#29756 setting up mirrors.u.c as an apt/country mirror finder to fix bug 94785.
It's the highest priority RT task I have; so pending this bug being fixed, I'm blocked on successful completion.
I'd suggest a fix far sooner than later would be preferable.

[Ursula Junque (ursinha)]

Fixed in stable r10609 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10609>

[Curtis Hovey (sinzui)]

Fixed released in launchpad-project 10.04.