schema_dictionary test doesn't clean up after itself

[Stewart Smith]

 --- .././plugin/embedded_innodb/tests/r/basic_show_tables.result 2010-03-28 06:56:19.612205904 +0300
 +++ .././plugin/embedded_innodb/tests/r/basic_show_tables.reject 2010-03-28 07:31:17.604705128 +0300
 @@ -1,5 +1,35 @@
  CREATE TABLE t1 (a int);
  show tables;
  Tables_in_test
 +branch
 +container
 +document
 +genstats_attributes
 +htmlcode
 +htmlpage

Because of left over tables from schema_dictionary.show test.

=== modified file 'plugin/schema_dictionary/tests/t/show.test'
--- plugin/schema_dictionary/tests/t/show.test 2010-03-02 02:31:50 +0000
+++ plugin/schema_dictionary/tests/t/show.test 2010-03-29 01:33:13 +0000
@@ -1,4 +1,5 @@
 create schema everything;
+use everything;

 -- source include/everything.sql

fixes it

[Jay Pipes (jaypipes)]

Actually, the fix should be to have the schema_dictionary test case drop the everything schema. Other tests should not depend on the results of another.

[Stewart Smith (stewart)]

On Wed, 31 Mar 2010 15:28:11 -0000, Jay Pipes <email address hidden> wrote:
> Actually, the fix should be to have the schema_dictionary test case drop
> the everything schema. Other tests should not depend on the results of
> another.

I think it does at the end of the test... IIRC it created the database,
loaded everything, did stuff, drop database. The only thing missing was
to actually use the database after creating it.

--
Stewart Smith