trunk - duplicate fiscal years

[Ferdinand]

r 3231
installing the account module installs demo data AND the wizard ask to create a fiscal year

IMHO fiscalyear needs the following checks
* no overlapping of fiscal years
* no gap between fiscal years

[Ferdinand (office-chricar)]

r 3231
installing the account module installs demo data AND the wizard ask to create a fiscal year

IMHO fiscalyear needs the following checks
* no overlapping of fiscal years
* no gap between fiscal years

[Ferdinand (office-chricar)]

the demo data creates no period code

[Claude Brulé (claude-brule-syleam)]

+1

kum (Open ERP) a écrit :
> ** Changed in: openobject-addons
> Status: New => Confirmed
>
>

--
SYLEAM
27 avenue Jean Mantelet
61000 Alençon
tel : [phone]
fax : [phone]

[kum (Open ERP) (kum-tinyerp)]

Hello Ferdinand,

 * no overlapping of fiscal years
     The following I think is being suggested by you:
     ->User cannot create a fiscal year with the same start date and end date as of any other existing fiscal year.
     ->User can also not create a fiscal year with the start and end dates falling in between of the start
         and end date of any other existing fiscal year.
    Is it correct?
 * no gap between fiscal years
     ->Could you please brief on what gap between fiscal years means,is it that if a fiscal year start from 2010/01/01 ends at 2010/12/31 then the next fiscal year must start from 2011/01/01.

Thank You

[Ferdinand (office-chricar)]

yes your comments are correct
* end date must be after the start date
if other fy exists:
* start and end date must not fall between existing start and end of existing fy
* start date must be either before the earliest start date or the day after an ending day
** this way it should also be possible
*** to shorten existing fy years ( which happens sometimes - at least in Austria we are allowed to change the length of the current fiscal year for important reasons)
*** to adjust the following start date
** make sure that period.fiscalyear_id points to the correct fy (start and end day fall in between start end of fiscal year)

[Claude Brulé (claude-brule-syleam)]

Ferdinand @ ChriCar a écrit :
> yes your comments are correct
> * end date must be after the start date
> if other fy exists:
> * start and end date must not fall between existing start and end of existing fy
> * start date must be either before the earliest start date or the day after an ending day
> ** this way it should also be possible
> *** to shorten existing fy years ( which happens sometimes - at least in Austria we are allowed to change the length of the current fiscal year for important reasons)
> *** to adjust the following start date
> ** make sure that period.fiscalyear_id points to the correct fy (start and end day fall in between start end of fiscal year)
>
>
This is true within a company.
It means that 2 companies can have the same fiscal years and periods

--
SYLEAM
27 avenue Jean Mantelet
61000 Alençon
tel : [phone]
fax : [phone]

[kum (Open ERP) (kum-tinyerp)]

Hello Ferdinand,

       I am attaching a patch regarding the problem please apply it and tell us if its correct or not.

Thank You

[Richard (John) Nopkins@Servosoft (richard-nopkins)]

hi guys,
my accountant used to shout at me due to this.
do we hv a solution?

[Richard (John) Nopkins@Servosoft (richard-nopkins)]

I remind please.......

[Ferdinand (office-chricar)]

sorry to not respond earlier

code seems correct.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Hello Experts,

We need to take care for multi company environment with Number of fiscal years.

Would you please provide your suggestions on this above specified issue ?

Thank you

[Ferdinand (office-chricar)]

I do not understand the question - which "Number"?

the check must be made for each company if defined.

the only problem I see - didn't check that - if "multicompany" IMHO the company_id in fy must be mandatory to be on the save side

* even if all companies have CURRENTLY the same fiscal year.
* for mergers and other reasons fiscal years may be shorter or longer than the usual 12 month for ONE of the companies.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Hello Ferdianand,

I am attchaning improved patch with consideration of company_id on fiscal year. So now check will see if the both the fiscal year (old and new) has same company and with same/in between start and end dates it does not allow to create it. But if the companies are different then we can create fiscalyears with same start and end dates as accepted.

Can you please check this patch ?

Note: Without demo data it allows to create Accounting Charts But if we create db with demo data (In demo data we have already created fiscalyear) it does not allow us to configure Account charts.

Thank you,
Mustufa (mra)

[Ferdinand (office-chricar)]

2 issues

IMHO the second check is not necessary if the newly created from date does not fall into an old fy the reverse is not possible

from comment 4
* no gap between fiscal years
     ->Could you please brief on what gap between fiscal years means,is it that if a fiscal year start from 2010/01/01 ends at 2010/12/31 then the next fiscal year must start from 2011/01/01.

exactly - the new fiscal year must start 2011/01/01 and not 2011/01/02 or 2011/02/01
this should be checked.
start of new fiscal year must be end date of the last fy + 1day
IMHO for comfort this should be a wizard
create new fy
just think that for oodo someone has to create new fy for every company ... user will not do it or ask the finance/admin if they can't work in the new fy - and the admin will not know - question who is the admin in SME? answer: the partner.

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Hello,

i am attaching improved patch here. can you check it. I think it will solve 2 issues.

Thank you,
Mustufa (mra)

[Mustufa Rangwala (Open ERP) (mra-tinyerp)]

Hello,

Overlapping of Fiscal years problem solved in lp:~openerp-dev/openobject-addons/trunk-dev-addons3 branch and it will be merged with Trunk addons soon.

Thank you,