Launchpad itself

IBuildFarmJobBehavior.slaveStatus requires too much duplication

Bug #549349 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
William Grant
Launchpad itself 10.04

Bug Description

IBuildFarmJobBehavior.slaveStatus implementations have too much asked of them. Builder.slaveStatus extracts builder_status itself, but all IBFJB implementations have to reextract it later. Implementations also all need to manually handle build status, build ID and logtail, all of which are common. Translations jobs even forget to extract logtail, making their build pages fairly useless.

This should all be refactored into a form that makes a lot more sense.

Tags: lp-soyuz qa-ok

Related branches

lp:~wgrant/launchpad/refactor-slavestatus
Brad Crittenden (community): Approve (code)
Diff: 215 lines (+51/-70)
7 files modified
lib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+6/-4)
lib/lp/buildmaster/model/builder.py (+11/-2)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+2/-2)
lib/lp/code/model/recipebuilder.py (+11/-23)
lib/lp/soyuz/model/binarypackagebuildbehavior.py (+11/-24)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+4/-14)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+6/-1)
William Grant (wgrant)
Changed in soyuz:
status: New → In Progress
assignee: nobody → William Grant (wgrant)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10610 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10610>

Changed in soyuz:
milestone: none → 10.04
status: In Progress → Fix Committed
tags: added: qa-needstesting
Julian Edwards (julian-edwards)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.