pieforms fieldset makes legend ids starting with numbers (invalid xhtml)

Bug #547963 reported by Penny Leach
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
François Marier

Bug Description

This really is a pieforms bug, but I don't know where to file those.

htdocs/lib/pieforms/pieform/elements/fieldset.php

$id = substr(md5(microtime()), 0, 4);

I made a temporary workaround with

$id = preg_replace('/[0-9]/', 'a', $id);

Which is probably not unique enough...

This bug was imported from eduforge.org, see:
https://eduforge.org/tracker/index.php?func=detail&aid=3134&group_id=176&atid=739

Revision history for this message
Nigel-catalyst (nigel-catalyst) wrote :

http://www.w3.org/TR/html4/types.html#h-6.2 is the part of the spec that says IDs must start with a letter (which took a bit of finding).

I'll fix it in pieforms.

Pieforms bugs should normally be reported to http://sourceforge.net/tracker/?atid=901453&group_id=182497&func=browse but I don't mind them here.

Revision history for this message
François Marier (fmarier) wrote :

Hi Penny,

Do you remember which branch you fixed this on? Also, instead of replacing all of the digits with 'a', why not just prepend the letter 'a' to the id string?

Changed in mahara:
assignee: Nigel-catalyst (nigel-catalyst) → nobody
milestone: none → 1.3.0
Revision history for this message
Penny Leach (mjollnir) wrote :

I didn't fix it, I just reported it. I'm not sure if Nigel fixed it in pieforms directly or not.

Changed in mahara:
status: Confirmed → Triaged
Changed in mahara:
assignee: nobody → François Marier (fmarier)
Changed in mahara:
status: Triaged → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.