Blocks with just floated content in them break view layout

Bug #547421 reported by Nigel-catalyst
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Richard Mansfield

Bug Description

If you have a block that has something in it that is floated - e.g. <table align="left">...</table> in the example I tried - then that makes the height of the block be 0. This means, among other things, that on the view edit screen, the controls for the block below appear way above where they should be (as they're positioned). See the attached screenshot for what I mean. Apparently on IE7 the behaviour may be even worse..

Potentially we could fix this with some kind of hack to add a clearer div - or some other kind of solution that will clear the bottom of the block below the float. The problem I have with that is that in a multicolumn layout, the clearing div will clear below anything in any of the other columns too, which will look wrong.

I hate to say it, but maybe we'll need to look at using <table>s for the view layout - or some other positioning mechanism - to make it work properly...

This bug was imported from eduforge.org, see:
https://eduforge.org/tracker/index.php?func=detail&aid=3364&group_id=176&atid=739

Revision history for this message
Nigel-catalyst (nigel-catalyst) wrote :

Attached broken-view-editor.png.

Changed in mahara:
milestone: none → 1.3.0
Changed in mahara:
status: Confirmed → Triaged
Changed in mahara:
assignee: nobody → Richard Mansfield (richard-mansfield)
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Clearing both on every new blockinstance fixes this with no obvious ill effects on my FF3.0, IE8 & Chrome.

Changed in mahara:
status: Triaged → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.