unserialized Testament.as_text() doesn't handle unicode revprops

Bug #54723 reported by John A Meinel
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
John A Meinel

Bug Description

I haven't spent any time to track down the specific bug, but the attached patch updates the test suite, which failes with a UnicodeError

I *think* the bug is that revprops are double serialized. (they are a stanza within a stanza).

So every time a stanza is parsed, it is decoded, even if it has already been decoded.

So it probably is a pure Testament bug, but the attached patch exposes it.

Related branches

Revision history for this message
John A Meinel (jameinel) wrote :

I came across this while fixing some other revprop code paths

Revision history for this message
John A Meinel (jameinel) wrote :

Working on this as part of fixing up bundles

Changed in bzr:
assignee: nobody → jameinel
importance: Untriaged → Medium
status: Unconfirmed → In Progress
Revision history for this message
John A Meinel (jameinel) wrote :

The associated branch changes when testaments encode/decode to utf8. Partially suggested by Holger Krekel

Changed in bzr:
status: In Progress → Fix Committed
John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.