Multiple attributes are not exported as links correctly

[James Westby]

Hi,

The following are not exported correctly:

  IDistroSeries.parent_series
  IDistroSeries.driver
  IProjectGroup.bug_tracker
  IProductSeries.product

meaning that you get an error if you try to access them with launchpadlib.

See bug 366102 for a similar error I introduced.

I am collecting the issues here as I find them while testing a change that will
prevent this from happening.

Thanks,

James

[Curtis Hovey (sinzui)]

I am not certain I understand the issue here. Reading the listed bug, is this a case where the WADL is defining the wrong name for the attribute? Is this caused by Choice or ReferenceChoice?

[James Westby (james-w)]

On Thu, 25 Mar 2010 18:54:28 -0000, Curtis Hovey <email address hidden> wrote:
> I am not certain I understand the issue here. Reading the listed bug, is
> this a case where the WADL is defining the wrong name for the attribute?
> Is this caused by Choice or ReferenceChoice?

It's caused by using Choice where ReferenceChoice is intended. This
causes the code that writes the wadl to not add "_link" to the name, but
the code that produces the json to do so, leading to a discrepancy. This
makes launchpadlib unable to use the attribute as it doesn't find the
json entry that the wadl says should be there.

The JSON is correct, so the wadl should be changed, and this is done by
using a ReferenceChoice and telling it the schema of the interface that
is referenced.

I have all the cases fixed in my local branch, but the slowness of
iterating with the tests means that it's taking far longer than just
changing the 5 declarations required.

Thanks,

James

[Curtis Hovey (sinzui)]

Thanks for the explanation. Launchpad will freeze in about 24 hours. If you need someone to review your branch in hopes to landed in in the next 18 hours, ping me on irc.

[Ursula Junque (ursinha)]

Fixed in stable r10596 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10596>

[James Westby (james-w)]

All tested on edge with no issues.

Thanks,

James

[Curtis Hovey (sinzui)]

Fixed released in launchpad-project 10.03.