moving a file in playlist creates duplicate entry

[Lars Volker]

In latest version 0.3.1.0+bzr2938 I get duplicate entries when moving a song inside a playlist. Instead of being moved, a copy appears at the destination.

[Lars Volker (lv)]

I forgot to mention, that I also checked it for version 0.3.1.1-0ppakarmic1beta4, but there it does NOT happen.

[Mathias Brodala (mathbr)]

Should be fixed with r2939.

[Lars Volker (lv)]

Yes. It does not occur in r2939 anymore. Thanks for the quick fix.

[Lars Volker (lv)]

This bug reappeared in the latest trunk version 0.3.1.99+bzr3024. Therefore i reopen the bug.

[Ernst (ernst-blaauw)]

Confirmed on bzr 3045

[Rocco Aliberti (eri.trabiccolo)]

I looked a bit the xlgui/playlist.py code, and I noticed that context.action is always

<flags GDK_ACTION_COPY GdkDragAction>

 so the istruction #736

if context.action == gtk.gdk.ACTION_MOVE:

is always false. I propose this "conservative" patch. Or do only if Playlist._is_drag_source.

Anyway the istruction #769 self.emit('track-count-changed', len(self.playlist)), should be performed only in case of a copy and not a move, i think.

[Mathias Brodala (mathbr)]

Fixed with r3046 in trunk and r2921 in 0.3.1.x.