Account : partner_bank to be partner_bank_id ?

[Numérigraphe]

In 5.0 and trunk, in the invoice object, the onchange functions for the partner and the bank details have a parameter partner_bank_id, but the name of the field is actually partner_bank.

In v5.0, I suggest the parameter name be changed in the signature of the onchange functions.

In the trunk, I suggest the field be renamed to partner_bank_id, which is more conform to the conventions - unless you chose to follow my humble suggestion for bug #405863, and split this into two distinct fields.

Lionel.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Fixed by revision 2672 <email address hidden>.
Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Lionel,

Thank you for pointing out this issue.

[Numérigraphe (numerigraphe)]

Jay (Open ERP) a écrit :
> Fixed by revision 2672 <email address hidden>.
> Thanks.
May I suggest you communicate about this API change? Just in case
someone wrote a function call with onchange_partner_id(...,
partner_bank_id=foo,...) like I have just done.
Lionel

[JMA(Open ERP) (jma-openerp)]

Hello Lionel,

Yes you are right that it could create problems for predecessor(which depend on account) modules.

But, It was a real mistake on code and, it is not at all good to continue this mistake for other modules too.

We have checked the modules on Official Addons(stable) which were using this method and this fix contains those changes.

We are thankful to you for pointing this out.

Thank you.

[JMA(Open ERP) (jma-openerp)]

Hello,

Let us be aware about any official module whether it still contains an error with this method.

Thanks.

[Numérigraphe (numerigraphe)]

revision 2672 <email address hidden> contains this change that I find a bit strange: Why remove this line ?
=== modified file 'account/account.py'
--- account/account.py 2010-03-17 12:36:40 +0000
+++ account/account.py 2010-03-23 09:59:56 +0000
@@ -932,7 +932,6 @@
                         l[2]['period_id'] = default_period
                 context['period_id'] = default_period

- accnt_journal = self.pool.get('account.journal').browse(cr, uid, vals['journal_id'])
         if 'line_id' in vals:
             c = context.copy()
             c['novalidate'] = True

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Lionel,

This was just an extra change. The line was unncessary.

And, JMA(OpenERP) is right about official modules.

Tell us if we still miss anything.

Thanks.

[Numérigraphe (numerigraphe)]

Thank you Jay and JMA.
> The line was unncessary.
>
Fine then, thanks.
> And, JMA(OpenERP) is right about official modules.
I sure trust you on this. I was rather thinking of extra, community,
partners' customizations ... so IMHO it should be announced as an API
change for everyone to check their own code.
Lionel

[Mantavya Gajjar (Open ERP) (mga)]

Hello,

Its fix and committees under trunk,
revision is : <email address hidden>