TableIdentifier is wrong in doGetTableDeinition for SHOW CREATE TABLE

Bug #544104 reported by Stewart Smith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Drizzle
Fix Released
Critical
Brian Aker
Cherry
Fix Released
Critical
Brian Aker

Bug Description

--- drizzled/table.cc 2010-03-19 01:45:39 +0000
+++ drizzled/table.cc 2010-03-22 11:58:40 +0000
@@ -1242,7 +1242,7 @@
   int error;
   bool error_given;

- TableIdentifier identifier(share->normalized_path.str);
+ TableIdentifier identifier(share->getSchemaName(), share->getTableName());

   error= 1;
   error_given= 0;

otherwise identifier SchemaName and TableName are garbage (well.. just the path) - which is useless if you're an engine that relies on these to find the table.

Stewart Smith (stewart)
Changed in drizzle:
assignee: Brian Aker (brianaker) → Stewart Smith (stewart-flamingspork)
Revision history for this message
Stewart Smith (stewart) wrote :

this needs a fix before anything works in embedded innodb. OR i have to go back to doing stupid things like identifier->getPath().c_str()+2

Changed in drizzle:
assignee: Stewart Smith (stewart-flamingspork) → Brian Aker (brianaker)
Revision history for this message
Brian Aker (brianaker) wrote :

This was fixed in trunk a bit ago.

BTW there were a number of places in the code where we just never passed in a legit schema/table.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.