Launchpad itself

Bug OOPSing due to missing LFC

Bug #542274 reported by William Grant
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Abel Deuring
Launchpad itself 10.04

Bug Description

Bug #396837 is currently OOPSing like http://paste.ubuntu.com/398034/. This is because of an attachment in comment #1 with a missing LFC. The "None application/x-gzip" first attachment on https://bugs.edge.launchpad.net/ubuntu/+source/hdparm/+bug/396837/+text suggests that it was LFA 28782220. But the librarian GC shouldn't have removed a file with a reference like that.

OOPS-1548K370: LocationError: (None, 'filesize')

See original description

Related branches

lp:~adeuring/launchpad/bug-542274
Aaron Bentley (community): Approve
Diff: 342 lines (+195/-9)
8 files modified
database/schema/security.cfg (+1/-0)
lib/canonical/launchpad/scripts/garbo.py (+36/-0)
lib/canonical/launchpad/scripts/tests/test_garbo.py (+24/-0)
lib/lp/bugs/browser/tests/bug-views.txt (+26/-0)
lib/lp/bugs/browser/tests/test_bugview.py (+67/-0)
lib/lp/bugs/doc/bugattachments.txt (+26/-6)
lib/lp/bugs/doc/bugzilla-import.txt (+1/-1)
lib/lp/bugs/model/bug.py (+14/-2)
Deryck Hodge (deryck)
Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: oops
Revision history for this message
Deryck Hodge (deryck) wrote :

stub, can you help get the data cleaned up for now to get the bug available again? And then we can have someone from bugs investigate what went wrong with the librarian GC.

Changed in malone:
assignee: nobody → Stuart Bishop (stub)
Revision history for this message
William Grant (wgrant) wrote :

There is at least one other. They should be easy to fix manually through the UI if more come up, but they're difficult to find.

Revision history for this message
Stuart Bishop (stub) wrote :

UI Code needs to cope with LFA's that have a NULL LFC. LFAs with expires set will end up in this state when they expire. They also end up in this state when something explicitly deletes the LFC, such as removing stuff from the Librarian for security reasons.

The LFA formatting widget thingy is supposed to cope with this. Are you using it or have you rolled your own? The filename is supposed to be displayed but no hyperlink IIRC.

Changed in malone:
assignee: Stuart Bishop (stub) → nobody
Deryck Hodge (deryck)
Changed in malone:
assignee: nobody → Abel Deuring (adeuring)
status: Triaged → In Progress
Ursula Junque (ursinha)
description: updated
Deryck Hodge (deryck)
Changed in malone:
status: In Progress → Fix Committed
milestone: none → 10.04
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10664 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10664>

tags: added: qa-needstesting
Deryck Hodge (deryck)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.