gnome-network-properties: put the cursor at the end of the proxy entry while typing

[Jean-Baptiste Lallement]

Binary package hint: gnome-control-center

When entering the proxy address in the proxy tab, the hostname is automatically extracted and replace the current entry. But the cursor is then placed at the beginning of the entry, before the last character resulting in typo. It should be put after the last character.

exemple:
Go to HTTP Proxy and enter (without interruption):
http://localhost
the result is
ocalhostl

ProblemType: Bug
Architecture: i386
Date: Fri Mar 19 17:20:22 2010
DistroRelease: Ubuntu 10.04
EcryptfsInUse: Yes
Package: gnome-control-center 1:2.29.92-0ubuntu1
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-16.25-generic
SourcePackage: gnome-control-center
Uname: Linux 2.6.32-16-generic i686

[Victor Vargas (kamus)]

It's strange but absolutely reproducible under fully upgraded Lucid.

[Jean-Baptiste Lallement (jibel)]

BTW it doesn't respect HIG 2.2 according to http://library.gnome.org/devel/hig-book/stable/windows-utility.html.en#windows-instant-apply
"Do not make the user press an OK or Apply button to make the changes happen, unless either:
[...]
    * the changes in the window have to be applied simultaneously to prevent the system entering a potentially unstable state. For example, the hostname and proxy fields in a network properties window.
"

A compromised could be to rewrite the content of the entry when the field loses focus.

[Jean-Baptiste Lallement (jibel)]

A prototype of a solution to mitigate this usability issue.
It disables the gconf value update on entry change and add a focus-out event to do the update. It's a bit less surprising for the user.

[Chris Coulson (chrisccoulson)]

Thank you for the patch. I've not had a look in great detail yet, but I do have 1 comment so far:

+{
+ GConfClient *client;
+ client = gconf_client_get_default ();
+
+ char const *entered_text = gtk_entry_get_text(entry);

It seems that you're leaking the GConfClient here

[Jean-Baptiste Lallement (jibel)]

updated patch according to previous comment.

[Sebastien Bacher (seb128)]

This dialog got rewritten in GNOME3, closing