GTG

Error in new_task of requeseter.py when adding tasks with tags

Bug #541943 reported by Zunbeltz Izaola on 2010-03-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	GTG	Fix Released	Low	Luca Invernizzi	GTG 0.2.9 "Don't open that! It's an alien planet!"

Bug Description

When adding a task with a tag via dbus there is the following error:

org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/hmi/gtg/GTG/core/dbuswrapper.py", line 107, in new_task
    nt = self.req.new_task(tags=tags)
  File "/hmi/gtg/GTG/core/requester.py", line 90, in new_task
    task.tag_added(t.get_name())
AttributeError: 'dbus.String' object has no attribute 'get_name'

I done a patch for it.

Tags:

Related branches

lp:~gtg/gtg/old-trunk

Revision history for this message

Zunbeltz Izaola (zunbeltz) wrote on 2010-03-19:

new_task_patch.diff Edit (392 bytes, text/plain)

Luca Invernizzi (invernizzi) on 2010-03-21

Changed in gtg:
status:	New → Won't Fix
assignee:	nobody → Luca Invernizzi (invernizzi)
importance:	Undecided → Low
milestone:	none → 0.3
status:	Won't Fix → In Progress

Revision history for this message

Luca Invernizzi (invernizzi) wrote on 2010-03-21:

Actually, the bug was in dbuswrapper.py (it should have passed the tag object instead of a string).
Since GTG is moving toward always passing strings instead of objects (it's faster and clearer from the developer POV), I've applied your patch and converted all GTG code to the new standard. Nice work!

Luca Invernizzi (invernizzi) on 2010-03-21