feed-pqm should match subject to avoid breaking threads in gmail

Bug #541586 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hydrazine
Fix Released
Medium
Unassigned

Bug Description

feed-pqm chooses its own subject for the message attached to the review; however this makes gmail see it as being a new thread. It should inherit the same subject as the last post on the review.

Martin Pool (mbp)
Changed in hydrazine:
status: New → Confirmed
importance: Undecided → Medium
summary: - feed-pqm should match subject
+ feed-pqm should match subject to avoid breaking threads in gmail
Revision history for this message
Martin Pool (mbp) wrote :

urk, this is kind of hard: launchpad requires you set a subject, but doesn't show you what it was on the previous message! :/

Revision history for this message
Martin Pool (mbp) wrote :

I think this is fixed in trunk; we'll see.

Changed in hydrazine:
status: Confirmed → Fix Released
Revision history for this message
Martin Pool (mbp) wrote :

Arguably this is caused by https://bugs.edge.launchpad.net/launchpad-code/+bug/390899 and https://bugs.edge.launchpad.net/launchpad-code/+bug/530505: merge review comments don't normally have a subject unless you use the api

Revision history for this message
Martin Pool (mbp) wrote :

This seems to be working for me. jml let me know if it still causes you pain.

Revision history for this message
Jonathan Lange (jml) wrote :

Thanks. Will do.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.