[dbus-branch] some small glichtes

Bug #540347 reported by Michael Vogt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
computer-janitor (Ubuntu)
Fix Released
High
Barry Warsaw

Bug Description

Binary package hint: computer-janitor

Some small issues with the dbus branch I notiiced:
- Show ignored is ignored on startup, re-toggling it fixes that
- the progressbar in the UI grows while in operation and looks too big
- startup is slow if the dbus daemon needs to be started (show progress while this happens?)

This is just for tracking.

Barry Warsaw (barry)
Changed in computer-janitor (Ubuntu):
assignee: nobody → Barry Warsaw (barry)
milestone: none → ubuntu-10.04
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Barry Warsaw (barry) wrote :

Merged in lp~mvo/computer-janitor/dbus to fix the progress bar part

Changed in computer-janitor (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Barry Warsaw (barry) wrote :

r236 for that change

Revision history for this message
Barry Warsaw (barry) wrote :

> - Show ignored is ignored on startup, re-toggling it fixes that

Can you provide more detail? I think it works for me:

% computer-janitor find
removable deb:libbind9-50
removable deb:libgupnp-1.0-2
removable deb:liblwres50
removable deb:linux-backports-modules-nouveau-lucid-generic
removable deb:linux-headers-2.6.32-14
removable deb:linux-headers-2.6.32-14-generic
removable deb:python-gtkhtml2
% computer-janitor ignore deb:libbind9-50
% computer-janitor ignore deb:liblwres50
% computer-janitor find
ignored deb:libbind9-50
removable deb:libgupnp-1.0-2
ignored deb:liblwres50
removable deb:linux-backports-modules-nouveau-lucid-generic
removable deb:linux-headers-2.6.32-14
removable deb:linux-headers-2.6.32-14-generic
removable deb:python-gtkhtml2

Now when I run computer-janitor-gtk initially I see only these packages:

libgupnp-1.0-2
linux-backports-modules-nouveau-lucid-generic
linux-headers-2.6.32-14
linux-headers-2.6.32-14-generic
python-gtkhtml2

If I toggle View->Show previous libbind9-50 and liblwres50 show up unchecked.

Revision history for this message
Barry Warsaw (barry) wrote :

> - startup is slow if the dbus daemon needs to be started

Here are some timings. On a cold start:

% ./run_from_checkout.sh
time to create system_bus: 0.0028440952301
time to get proxy: 2.63479399681
time to get interface: 1.4066696167e-05

On a warm start (janitord is running):

time to create system_bus: 0.0017249584198
time to get proxy: 0.000355005264282
time to get interface: 7.86781311035e-06

Is it worth adding timer to pop up a dialog, say after 1 second? That would
avoid a flash for the warm start (which should be more common I think).

Revision history for this message
Barry Warsaw (barry) wrote :

I think most of the issues except the one I don't understand are fix committed.

Changed in computer-janitor (Ubuntu):
status: In Progress → Incomplete
Barry Warsaw (barry)
Changed in computer-janitor (Ubuntu):
status: Incomplete → Fix Committed
Barry Warsaw (barry)
Changed in computer-janitor (Ubuntu):
milestone: ubuntu-10.04 → maverick-alpha-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.