Nested progress bar not cleaned up on early exit

[Matthew Paul Thomas]

Bazaar 0.8.2

On pressing Ctrl+C during a bzr branch, I got the error message: "bzr: ERROR: A nested progress bar was not 'finished' correctly."

That's confusing the operation with the feedback; there was nothing incorrect about the progress bar, I just cancelled it. The message should instead be "bzr: branch cancelled." or something like that.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Paul Thomas wrote:
> Public bug reported:
>
> Bazaar 0.8.2
>
> On pressing Ctrl+C during a bzr branch, I got the error message: "bzr:
> ERROR: A nested progress bar was not 'finished' correctly."

That's not deliberate. "A nested progress bar was not 'finished'
correctly" indicates a programming error. Somewhere there's a progress
bar not being cleaned up properly when we exit early. Do you recall
what phase "bzr branch" was in when this happened?

> That's confusing the operation with the feedback; there was nothing
> incorrect about the progress bar, I just cancelled it. The message
> should instead be "bzr: branch cancelled." or something like that.

The typical output is "bzr: interrupted"

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFExg9t0F+nu1YWqI0RAr+hAJ4tn0HH+FCQY8Qa1Ze6hvxJOS63vgCghDQz
bTKvN9YaYeYUdc8T/V1UfGs=
=YQfF
-----END PGP SIGNATURE-----

[Matthew Paul Thomas (mpt)]

No, sorry, it's left my bash history. I'll report it more attentively if it happens again.

[Michael Ellerman (michael-ellerman)]

It's still a bug, so leave it in Needs Info until we can work out what the cause is.

[John A Meinel (jameinel)]

I was able to reproduce this using bzr-0.8.2, and with bzr.dev.

Specifically, if you just do a 'bzr branch' with something that takes a while, wait a little bit while it fetches (I think inventory needs to already be processed).
Then doing ^C I get:
liliana % ~/dev/bzr/bzr-0.8/bzr --no-plugins branch ~/dev/bzr/bzr.dev
bzr: ERROR: A nested progress bar was not 'finished' correctly.
/home/jameinel/dev/bzr/bzr-0.8/bzrlib/lockable_files.py:107: UserWarning: file group LockableFiles(<bzrlib.transport.local.LocalTransport url=/home/jameinel/dev/,tmp/bzr.dev/.bzr/repository/>) was not explicitly unlocked
  warn("file group %r was not explicitly unlocked" % self)

I was able to reproduce this with bzr.dev. You just have to wait a little bit, about after the first few fetches occur.

This is the traceback:
Traceback (most recent call last):
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 697, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 659, in run_bzr
    ret = run(*run_argv)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/commands.py", line 281, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/builtins.py", line 675, in run
    revision_id, basis_dir)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/bzrdir.py", line 618, in sprout
    result_repo.fetch(source_repository, revision_id=revision_id)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/repository.py", line 242, in fetch
    pb=pb)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/decorators.py", line 51, in write_locked
    return unbound(self, *args, **kwargs)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/repository.py", line 1809, in fetch
    pb=pb)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/fetch.py", line 112, in __init__
    self.nested_pb.finished()
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/progress.py", line 187, in finished
    self._stack.return_pb(self)
  File "/home/jameinel/dev/bzr/bzr.dev/bzrlib/progress.py", line 144, in return_pb
    raise errors.MissingProgressBarFinish()
MissingProgressBarFinish: A nested progress bar was not 'finished' correctly.

[John A Meinel (jameinel)]

bumping to 0.11

[John A Meinel (jameinel)]

Aaron fixed this for 0.12