Quickshot

checkForUser function is inaccurate

Bug #538873 reported by Kevin Godby
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Quickshot
Fix Released
High
Luke Jennings

Bug Description

The checkForUser function (in the userutils.py file) fails if the quickshot user has been removed but the home directory was left behind.

Luke Jennings (ubuntujenkins)
Changed in quickshot:
assignee: nobody → Luke Jennings (ubuntujenkins)
importance: Undecided → High
status: New → In Progress
Revision history for this message
Luke Jennings (ubuntujenkins) wrote :

Fixed in revision 44. Thank you for reporting the bug.

Changed in quickshot:
status: In Progress → Fix Released
Revision history for this message
Kevin Godby (godbyk) wrote :

The bug isn't actually fixed. If I manually 'sudo mkdir /home/quickshot', the the checkForUser function still fails.

checkForUser should return True if and only if the user actually exists, not if a particular directory exists.

Changed in quickshot:
status: Fix Released → Confirmed
Luke Jennings (ubuntujenkins)
Changed in quickshot:
status: Confirmed → In Progress
Revision history for this message
Luke Jennings (ubuntujenkins) wrote :

Thats a very good point I will look into a better way of doing it

Revision history for this message
Luke Jennings (ubuntujenkins) wrote :

I have made a change in revision 45 please see if you think that is a suitable detection of the user.

Revision history for this message
Luke Jennings (ubuntujenkins) wrote :

I have made another change in revision 47. Quickshot now uses the id bash command to detect the user.

Changed in quickshot:
status: In Progress → Fix Committed
Luke Jennings (ubuntujenkins)
Changed in quickshot:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.