Can't substitute Review URL in commit message
Bug #538798 reported by
Stefano Rivera
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Tarmac |
Fix Released
|
Wishlist
|
Paul Hummer | ||
Bug Description
Ibid (launchpad.
Related branches
lp:~stefanor/tarmac/review-url-substitution-538798
- Paul Hummer: Pending requested
-
Diff: 25 lines (+7/-1)1 file modifiedtarmac/plugins/commitmessage.py (+7/-1)
lp:~rockstar/tarmac/review-url-commit-message
- dobey: Approve
-
Diff: 94 lines (+24/-5)4 files modifiedtarmac/bin/commands.py (+2/-4)
tarmac/plugins/commitmessage.py (+5/-0)
tarmac/plugins/tests/test_commitmessage.py (+7/-1)
tarmac/utility.py (+10/-0)
Revision history for this message
| Paul Hummer (rockstar) wrote | #1 |
| Changed in tarmac: | |
| status: | New → Triaged |
| importance: | Undecided → Wishlist |
| Changed in tarmac: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Paul Hummer (rockstar) |
| milestone: | none → tarmac-0.5 |
| Changed in tarmac: | |
| status: | In Progress → Fix Committed |
| Changed in tarmac: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
So I guess the real fix to this bug is to provide the review url to the commit message templating (which Gavin may or may not have done already).
In the process of doing this, I think it would be worthwhile to do something about bug #316694