lyric viewer doesn't load lyrics when launched with a file argument

[Jason Conti]

When launching exaile with a file argument, the lyrics panel will be blank until another track starts or the current track is restarted. This seems to be because the playback_track_start event is sent before the exaile_loaded event, so the callbacks aren't added yet. This is with bzr revision 2896. The easiest fix seems to be to initialize the lyric panel when the plugin is enabled (after the exaile_loaded event) by calling playback_cb manually.

[reacocard (reacocard)]

Attached branch doesn't appear to fix the issue, lyrics are still blank for me.

[Jason Conti (jconti)]

I think I see the problem, I was only testing audio files with embedded lyrics tags, which works as soon as the lyrics module is loaded. When I tested with files that needed lyrics to be fetched from a remote site, it wasn't working. Tracked down the problem. The lyric search provider plugins aren't loaded until long after exaile_loaded is sent, so they aren't available when the lyrics viewer is setting up. I pushed a new fix that seems to work to the branch, adding a callback for lyrics_search_method_add, which refreshes the lyrics. Also threw a refresh button in there to manually update the lyrics. If it still doesn't properly update, at least you can fetch the lyrics without restarting the track (though it seems to work fine now for me).

[reacocard (reacocard)]

Excellent, that fixed it for me. I've merged your branch in trunk/2901.