Translation templates build gets wrong branch URL
Bug #537866 reported by
Jeroen T. Vermeulen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
wgrant noticed that TranslationTemp
To fix this, it would be enough to pass the TranslationTemp
Related branches
lp:~jtv/launchpad/bug-537866
Merged
into
lp:launchpad
- Guilherme Salgado (community): Approve
-
Diff: 695 lines (+372/-77)9 files modifiedlib/lp/buildmaster/interfaces/buildfarmjobbehavior.py (+1/-1)
lib/lp/buildmaster/model/buildfarmjobbehavior.py (+94/-10)
lib/lp/buildmaster/tests/test_buildfarmjobbehavior.py (+80/-8)
lib/lp/code/model/recipebuilder.py (+11/-2)
lib/lp/soyuz/doc/buildd-slavescanner.txt (+4/-3)
lib/lp/testing/factory.py (+87/-40)
lib/lp/translations/doc/translationtemplatesbuildbehavior.txt (+41/-12)
lib/lp/translations/model/translationtemplatesbuildbehavior.py (+17/-1)
lib/lp/translations/tests/test_translationtemplatesbuildbehavior.py (+37/-0)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in rosetta: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Shamelessly lumping in an unrelated issue: TranslationTemp latesBuildBehav ior should override verifySlaveBuildID to accept the type of id strings generated by TranslationTemp latesBuildJob. getName.
Of the base verifySlaveBuildID, the part that checks the BuildQueue is generically useful so that should probably become a helper.