a progress report while copying from the DVD is missing

[flipflip]

The attached patch against dvdbackup-0.4.1 adds a --progress|-p flag, which will enable a progress report ("xx% done, x/y MiB") while copying from the DVD in DVDCopyBlocks().

[Benjamin Drung (bdrung)]

Thanks for the patch. At a glance it looks good.
One feature I like to see: Update the status line in a VT compliant terminal.

[flipflip (flipflip)]

I don't understand. Do you like to see some sort of abstraction that can handle the "\r" stuff in every terminal? Curses? Wouldn't "\r" work in every terminal?

[Benjamin Drung (bdrung)]

I didn't test your patch and wasn't aware that "\r" does exactly what I wanted.

[Benjamin Drung (bdrung)]

Thanks for the patch. I have modified it slightly (modified patch attached) and applied it in bzr revision 73.
* Mention the new switch in the man page.
* Convert spaces to tabs and change the coding style to my preferences.
* print progress on stdout instead of stderr
* simplified calculation to totalMiB = (float)(total) / 512.0f;

[flipflip (flipflip)]

Great!

We should probably add some code that detects if we're running in an interactive terminal or not. If we're running from a script or a GUI frontend we should probably not use "\r" but rather print a full line for each progress update. I think isatty() can do the detection. I have local modified version that uses this but I didn't have much time to test it.

What do you think?

[Benjamin Drung (bdrung)]

Do we need this? I ran "dvdbackup -pM > log" and log contains one line per progress update.

It would be nice to have an overall status.

[flipflip (flipflip)]

I think a GUI would use a line oriented input (fgets(), $foo = <STDIN>, etc.) to get the output of dvdbackup. And that would block until a \n is received.

What if you

cat log

One line or many lines? Isn't your reader (less?) assuming a DOS file and translating \r to \n?

[Benjamin Drung (bdrung)]

"cat log" outputs only one line. So you are right. I used gedit (less show ^M and no new lines).

It would be nice to have a detection. Patches are welcome ;) You may want to open a new bug report then.