Not possible to get land around headquarter after destroying it

[Timowi]

Reported by EisNerd in irc:

He could not get the land after he destroyed the headquarter. The computerplayer has no more military builings but still influence on the land.

I could reproduce it with the replay.

[Raul Ferriz (raul.ferriz)]

Loading this replay with current trunk version (debug build) I see a HeadQuarters for yelow player just above well, when on screenshot a 0% buildingsite is showed.

Replay instantly autopaused because has lost synchronization.

[Raul Ferriz (raul.ferriz)]

Forgive autopaused and lost of sync. Was trying a non-standard build.

[Timowi (timo-wingender)]

It's called "replay leading to this bug" because it's before the headquarter is destroyed. ;) It's likely your changes in the battle code cause the desyncs. I've tested it with bzr-trunk-5020. It runs fine until the end.

I think I know where the problem is. The military influence of the computerplayer is 0 before the headquarter is destroyed. So it is 64636 after destroying it. I will fix the loading code. :)

[Timowi (timo-wingender)]

Introduced by me in bzr-trunk-5016
and fixed by me in bzr-trunk-5021

[SirVer (sirver)]

Releasd in build15-rc1