create_bank_account(...) function does risky assumptions

[sraps (Alistek)]

The problem is that create_bank_account(...) function does assumption, that country_id from res.partner object is the country for bank account of the partner as well. This assumption is in few words invalid.

Again it is common practice, that partner from nearby country does business in your country directly (especially for distributors), but have account number in your country. So what happens? We are trying to convert the BIC-> IBAN by applying wrong country ID.

[Pieter J. Kersten (EduSense BV) (pieterj)]

The country of the partner is the only info available to build upon. If the account is a SEPA account, the country code is encoded in the account number already, eliminating the need for assumptions.

The result of a wrong assumption is that no online conversion can be made, resulting that no bank can be matched, hence that a bank account in the wrong country with the right info is created. The only other option is to scan all available online conversion routines to find one that does match, resulting in long delays and possibly false positives, which is far worse.

You can simply hand edit the resulting bank account afterwards. As this is only once per partner, for most organizations this is of low importance.

For now, I'll mark this as 'won't fix'.