qcommit: ignored files added when non-versioned and select all checked

[Alexander Belchenko]

If the tree has ignored folder with files in it and in qci user checks "show non-versioned files" and then "select all", then ignored folder and files in it will be added and committed.

To reproduce:

bzr init 4
cd 4
mkdir foo
cd foo
echo > 1.txt
echo > 2.txt
echo > 3.txt
echo > 4.txt
mkdir trash
cd trash
echo > 5.txt
cd ../..
bzr ignore trash
bzr qci

See attached screenshot. After user pressed OK following happens:

C:\Temp\4>bzr qci
Run command: bzr add --no-recurse foo foo/trash foo/1.txt foo/2.txt foo/3.txt foo/4.txt foo/trash/5.txt
adding foo
adding foo/trash
adding foo/1.txt
adding foo/2.txt
adding foo/3.txt
adding foo/4.txt
adding foo/trash/5.txt
Run command: bzr commit -m xxx foo .bzrignore foo/trash foo/1.txt foo/2.txt foo/3.txt foo/4.txt foo/trash/5.txt
Committing to: C:/Temp/4/
added .bzrignore
added foo
added foo/1.txt
added foo/2.txt
added foo/3.txt
added foo/4.txt
added foo/trash
added foo/trash/5.txt
Committed revision 1.

Tested with 0.18.3 and 0.18.0

[Alexander Belchenko (bialix)]

The real problem is that ignored folder trash is invisible here. And we should not blindly add ignored folders and files, IMO.