replace filesystem code with PhysicsFS (physfs)

Bug #536613 reported by Sigra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Expired
Undecided
Unassigned

Bug Description

Replace the homemade filesystem code with PhysicsFS (physfs). Then we would have less code to maintain. PhysicsFS can handle 7z-files, a format that is superior to zip-files. Discussed here:
[https://sourceforge.net/mailarchive/message.php?msg_id=200607231739.05059.Florian.Weber%40pfaffenhofen.de] (here a patch was already promised)
[https://sourceforge.net/mailarchive/message.php?msg_id=4807A388.5060700%40home.se]

If it is found that PhysicsFS lacks a feature that Widelands needs, please post a feature request to PhysicsFS (at [https://bugzilla.icculus.org/]) and post a link to it here.

Revision history for this message
dwarik (dwarik) wrote :

does physfs support zip writing these days? i think that was the reason it wasn't included earlier

Revision history for this message
Sigra (sigra) wrote :

> does physfs support zip writing these days? i think that was the reason it wasn't included earlier

From http://icculus.org/physfs/:
"The programmer defines a "write directory" on the physical filesystem. No file writing done through the PhysicsFS API can leave that write directory, for security."

Revision history for this message
Nasenbaer (nasenbaer) wrote :

I set this to incomplete, as:
1) no work was done until now on this
2) our current system works quite fine
3) I don't see a reason for adding even one more dependecy for Widelands

4 and most important) if one wants to implement this feature, we first need a valid blueprint how physfs would improve Widelands and how to add these improvements.

Changed in widelands:
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
Revision history for this message
SirVer (sirver) wrote :

We recently had a security bug because our implementation can write anywhere on the file system. I am currently all for the physicsfs library, but I haven't checked it out.

Changed in widelands:
status: Expired → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.