Soldier's list updating too slow in miltary buildings

[astuur]

When you expell soldiers from military sites, you sometimes get not the soldier you clicked on.
I had long been thinking it was me aiming badly, but its not so :)
Especially when you use the sorting feature (for skill points) and kick more than one in a row, it seems that the display has not updated yet.
So what you kick is not what you see.

[Nicolai Hähnle (nha)]

I'm not sure that I'm seeing exactly the problem you are describing; in particular, you definitely always kick the soldier that was selected, but I also noticed that the selection in the soldier list doesn't get properly maintained when the list of soldiers changes.

I've cleaned up that code in my branch lp:~nha/widelands/refactor-building-ui to fix the issue I am seeing - could you please try whether this also fixes your problem? If it doesn't, could you please describe more accurately what goes wrong in your opinion? Ideally with a save game plus a short list of steps to reproduce the problem.

[Astuur (wolfsteinmetz)]

I guess you most likely have found the cause.
I simply made sure I marked untrained soldiers before I kicked them,
and found that the result when doing so quickly and repeatedly,
was not as expected (from the badges above their heads)
I also saw that the sorted list seemed to change order while I was trying to mark the next one.
It looked like updating the order when some soldiers were leaving and others coming in,
was slow and sometimes led to unpredictable results
So it may well be a problem of marking the correct soldier after all.
I have not seen this particular thing in some time and cannot now supply a save game
that shows the bug - sorry.
I will gladly check this again when I come across a precompiled version that includes your fix.
( I have no develoment environment and no knowledge to compile myself)
Thanks for working on this

[Nicolai Hähnle (nha)]

I've committed my changes to trunk now, I'm assuming they fix your problem. If not, please let us know.

[SirVer (sirver)]

Released in build16-rc1