Module l10nch: bug with the reference number

[Open Net Sàrl]

While printing a BVR with the module l10n_ch, one can encounter a bug, espacially if the invoice number has a slash in it.
When an invoice is created, a small function called '_convert_ref( ... )' removes all occurences of slashes.
Within the l10n_ch module, while printing a BVR, all characters but digits are converted to 0's (the digit), so that the reference number that is printed does not correspond to what is in the database.
Example:
    FC00020021/2010 becomes:
        account_invoice table: FC000200212010
        printed on the BVR: 000002002102010
After that, importing the BVR's can not do its job because the reference has no chance to find anything.
I suggest the following change in l10n_ch/report/bvr.py, line 108:
          -- invoice_number = re.sub('[^0-9]', '0', o.number)
          ++ invoice_number = re.sub('[^0-9]', '', o.number)

Best regards

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,
If you read the BVR manual
http://www.postfinance.ch/pf/content/fr/seg/biz/customer/download/doc.html
You will see that ref numbers are validating using the modulo 10 validation algorithm. So as this algorithm can only check
numeric data, non numeric chars are not allowed in reference numbers.

Regards

Nicolas

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

An other point the len of the ref is used to determine the type of postfinance account =>
If it is a post account or a bank account hosted by postfinance. So replacing special chars with empty strings is not a good idea.

Regards

Nicolas

[Open Net Sàrl (openerp-open-net)]

Thank you for your comments.

The modification i am proposing is taking place before the line that pads everything to the right so that 26 digits are always generated.
Remember: this modification introduces the same reference number as do the official code, the mod10 excepted.
No invalid characters are introduced.

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,

Sorry, I did not understand well your ticket. It 'is right that the reference column in the account_move_line will not match the printed reference. It is due to the fact that the _convert_ref function of account.invoice has been changed.

The best solution will be to override this function in account invoice, but it may have unexpected side effect. So we have to modified the wizard and report code.

Your patch is a part of the solution, but the modification has to be propagated to bvr_import.py

I have provided a patch, feel free to test it.

Regards

Nicolas

[Jay Vora (Serpent Consulting Services) (jayvora)]

It has been Fixed by revision 2731 <email address hidden>.
Thanks.