Portability: Use $SOCKETDIR variable instead of hardcoded references to /var/run/screen?

[ermo | Rune Morling]

Dustin,

For Foresight Linux, I need to patch the below three files with a different socketdir as our screen package saves sessions in /tmp/uscreens/ instead of /var/run/screen.

<ermo@mrwing>:[~/conary/builds/byobu/byobu-2.62]
(92)$ grep /var/run/screen usr/bin/*
usr/bin/byobu-config:RELOAD_FLAG="/var/run/screen/S-"+USER+"/"+PKG+".reload-required"
usr/bin/byobu-janitor:RUN="/var/run/screen/S-$USER"
usr/bin/byobu-select-profile: touch "/var/run/screen/S-$USER/$PKG.reload-required"

How about creating a /usr/share/byobu/socketdir file, which simply contains "SOCKETDIR=/var/run/screen" and source it in the above three scripts and replace the hardcoded strings?

That way, packagers only need to change SOCKETDIR in one place.

I've also noticed that usr/bin/byobu-config contains a hardcoded reference to /bin/bash, which is probably not good for portability to e.g. FreeBSD and which should probably also be mentioned as a package dependency (couldn't find any mention of it in the release tarball)?

[Dustin Kirkland  (kirkland)]

I agree in principle with the suggestion, though I think
/etc/byobu/socketdir would be more appropriate, no?

How about /etc/byobu/socketdir instead, such that sysadmins (in
addition to packagers) could tweak this?

Regarding the bash reference, sure ... please open a different bug for that ;-)

[ermo | Rune Morling (ermo)]

/etc/byobu/socketdir sounds like a better idea, yes.