Compile error with ACPI off

[Pascal de Bruijn]

While compiling a minimal kernel without ACPI, I got the following error:

  LD arch/i386/lib/built-in.o
  CC arch/i386/lib/bitops.o
  AS arch/i386/lib/checksum.o
  CC arch/i386/lib/delay.o
  AS arch/i386/lib/getuser.o
  CC arch/i386/lib/memcpy.o
  AS arch/i386/lib/putuser.o
  CC arch/i386/lib/strstr.o
  CC arch/i386/lib/usercopy.o
  AR arch/i386/lib/lib.a
  GEN .version
  CHK include/linux/compile.h
  UPD include/linux/compile.h
  CC init/version.o
  LD init/built-in.o
  LD .tmp_vmlinux1
arch/i386/kernel/built-in.o(.init.text+0x13eb): In function `setup_arch':
: undefined reference to `check_acpi_pci'
make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/home/pmjdebruijn/kernel/ubuntu/linux-source-2.6.15-2.6.15'
make: *** [stamp-build] Error 2

It seems some Ubuntu specific patch break nonACPI support.

[Pascal de Bruijn (pmjdebruijn)]

This should fix the issue. The kernel compiles and boots with the patch.

Please consider that I'm not an experienced kernel developer or C programmer.

Thanks to <email address hidden>#ubuntu-kernel!

[Ben Collins (ben-collins)]

On Thu, 2006-07-20 at 15:19 +0000, Pascal de Bruijn wrote:
> This should fix the issue. The kernel compiles and boots with the patch.
>
> Please consider that I'm not an experienced kernel developer or C
> programmer.

You'll need to attach the patch to the bug report from the web
interface, not via email.

Also, not sure why you disabled ACPI support anyway. It can be disabled
on the kernel command line with acpi=off.

[Pascal de Bruijn (pmjdebruijn)]

> You'll need to attach the patch to the bug report from the web
> interface, not via email.
Sorry I don't follow.

> Also, not sure why you disabled ACPI support anyway. It can be disabled
> on the kernel command line with acpi=off.
Well it's intended for a low memory, low diskspace system, so every byte counts. Either way, it should be fixed.

[Dennis Kaarsemaker (dennis)]

Ben: lp suddenly no longer displays attachments in emails. The patch was
added to the bug though.

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Do you still have this issue with the latest release of Ubuntu ?

[Pascal de Bruijn (pmjdebruijn)]

Sorry I can't test it anymore, I gave the player to a Windows user.

Is there any reason to believe this got fixed in the newer kernel?

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Well, I don't exactly know, but the kernel has changed a lot since you reported that bug.

[Pascal de Bruijn (pmjdebruijn)]

Sorry. I got two bugs mixed up. Never mind my last comment.

I'm sure the issue was with the Ubuntu patchset and not the vanilla kernel sources.

If the above patch still applies properly the problem persists. If you look at the patch it was a minor mistaken of putting an if statement too late.

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Well I don't know how to check this, so I will leave it as unconfirmed.

[Leann Ogasawara (leannogasawara)]

I just test compiled the latest Hardy Heron kernel source with ACPI support disabled and was able to successfully finish compiling. I'm marking this "Fix Released" against the Hardy kernel and closing this against 2.6.15 as it does not qualify for a stable release update. Thanks.