getRequestedReviews does not follow its docstring, returns too many proposals
Bug #535141 reported by
James Westby
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
James Westby | ||
Bug Description
The getRequestedReviews method that I added is broken, returning too many
resutls.
It returns the merge proposals owned by me as well as those it is supposed to
return.
Thanks,
James
Related branches
lp:~james-w/launchpad/fix-getRequestedReviews
- Graham Binns (community): Approve (code)
- Aaron Bentley (community): Needs Fixing
-
Diff: 52 lines (+27/-3)2 files modifiedlib/lp/code/model/hasbranches.py (+1/-1)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+26/-2)
| Changed in launchpad-code: | |
| status: | New → In Progress |
| assignee: | nobody → James Westby (james-w) |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.03 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Tim Penhey (thumper) wrote | #2 |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
Revision history for this message
| James Westby (james-w) wrote Re: [Bug 535141] Re: getRequestedReviews does not follow its docstring, returns too many proposals | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 535141 Fix released | #4 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10467 <http://