Does not fit well with Dark Gtk Themes

Bug #534073 reported by appi2012
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Activity Journal
Fix Released
Medium
Unassigned

Bug Description

The Colors used in drawing the custom widgets that are a part of Gnome Activity Journal do not always fit with the user's. For example, GAJ does not use the selected fg color when drawing the title "Today" on the colored title section. Also, it lightens the fg_color to create a faded color (in the histogram, for example), when in a dark theme, this will not work. Instead, GAJ should use a mixing techniques (like the ones used for the "Morning", "Afternoon", etc. labels. Finally, the histogram is always white, which makes it stand out tremendously when using dark themes.

Revision history for this message
Randal Barlow (email-tehk) wrote :

Works fine here on the themes I tested. Any specific themes which have issues that I could take a look at?

Revision history for this message
Randal Barlow (email-tehk) wrote :

Thank you for pointing out these issues.

I corrected histogram font coloring in r737 using combined colors and I plan to do the same with some other items. The day label used text_gc[gtk.STATE_SELECTED] if leading other wise it uses text_gc[gtk.STATE_INSENSITIVE] instead of fg_gc. I changed this in r738.

The histogram background is colored with your treeview base color, which I assume you have set to white. This is behaving as expected.

Changed in gnome-activity-journal:
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Randal Barlow (email-tehk) wrote :

Changing this to fixed unless someone can point out any other troublesome areas

Changed in gnome-activity-journal:
status: In Progress → Fix Committed
Changed in gnome-activity-journal:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.