make changing default coin supply setting possible

Bug #533866 reported by GoGi
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Return To The Roots
Status tracked in S25client
S25client
Fix Released
Wishlist
FloSoft

Bug Description

This patch adds an add-on. If activated, players can choose the default setting, coins off or coins on, for newly built military buildings.

What is missing are suitable graphics for the new progressbar, maybe a coin and a crossed-out-coin or something like that.

Tags: all-rev
Revision history for this message
GoGi (lp-gogi) wrote :
Changed in s25rttr:
status: New → In Progress
Revision history for this message
FloSoft (flosoft) wrote :

divan, can you have a look if the patch does work?

Revision history for this message
Stefan Kriwanek (Divan) (dev-stefankriwanek) wrote :

I have changed some things and made an own patch that seems to work.
GoGi, you haven't sent your AddonAllowCoinSetting.h. Do a "bzr add your_new_file" next time ;)

I just saw, my patch still lacks:
- a savegame version increase
- a tooltip to the new button in iwMilitary that represents the current status. I found it difficult to find a shorter term for "default coin distribution on/off"

Revision history for this message
Stefan Kriwanek (Divan) (dev-stefankriwanek) wrote :

Full and final version, it works and is tested. Instead of a progress bar I added the same coin button to the military settings (if addon enabled) as in iwMilitaryBuilding and as GoGi proposed. I also had to increase iwAddon's height a bit (there's not much space left now...)

GoGi, thanks for your code!

Revision history for this message
FloSoft (flosoft) wrote :

I merged the addon from Johann (see branches)

perhaps you can adapt the other one so you can switch the setting ingame (like your patch)

tags: added: all-rev
Revision history for this message
Stefan Kriwanek (Divan) (dev-stefankriwanek) wrote :

done

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.