assertion failure in bob state handling

[Nicolai Hähnle]

The following assertion was triggered (trunk revision 5007):

widelands: /home/prefect/dev/widelands/trunk/src/logic/bob.h:304: Widelands::Bob::State& Widelands::Bob::top_state(): Assertion `m_stack.size()' failed.

A replay to reproduce is available. Backtrace:

#3 0x004eb648 in *__GI___assert_fail (assertion=0x862c3f2 "m_stack.size()", file=0x862c3c0 "/home/prefect/dev/widelands/trunk/src/logic/bob.h", line=304,
    function=0x862d920 "Widelands::Bob::State& Widelands::Bob::top_state()") at assert.c:81
#4 0x083262ba in Widelands::Bob::top_state (this=0x9b2dc88) at /home/prefect/dev/widelands/trunk/src/logic/bob.h:304
#5 0x083f5f7d in Widelands::Carrier::notify_ware (this=0x9b2dc88, game=..., flag=1) at /home/prefect/dev/widelands/trunk/src/logic/carrier.cc:387
#6 0x083be531 in Widelands::Road::notify_ware (this=0xd126760, game=..., flagid=Widelands::Road::FlagEnd)
    at /home/prefect/dev/widelands/trunk/src/economy/road.cc:577
#7 0x083ad7db in Widelands::Flag::call_carrier (this=0xd30c1a8, game=..., item=..., nextstep=0xd47bda8)
    at /home/prefect/dev/widelands/trunk/src/economy/flag.cc:557
#8 0x083b0b10 in Widelands::WareInstance::update (this=0x89566e8, game=...) at /home/prefect/dev/widelands/trunk/src/economy/ware_instance.cc:349
#9 0x083ad08a in Widelands::Flag::add_item (this=0xd30c1a8, game=..., item=...) at /home/prefect/dev/widelands/trunk/src/economy/flag.cc:356
#10 0x083f5ccd in Widelands::Carrier::drop_item (this=0xd15f588, game=..., state=...) at /home/prefect/dev/widelands/trunk/src/logic/carrier.cc:308
#11 0x083f57ec in Widelands::Carrier::transport_update (this=0xd15f588, game=..., state=...) at /home/prefect/dev/widelands/trunk/src/logic/carrier.cc:183
#12 0x0835cfcc in Widelands::Bob::do_act (this=0xd15f588, game=...) at /home/prefect/dev/widelands/trunk/src/logic/bob.cc:223
#13 0x0835cee6 in Widelands::Bob::act (this=0xd15f588, game=..., data=834) at /home/prefect/dev/widelands/trunk/src/logic/bob.cc:207
#14 0x0830c13d in Widelands::Cmd_Act::execute (this=0x9b2c6f0, game=...) at /home/prefect/dev/widelands/trunk/src/logic/instances.cc:107
#15 0x0835332e in Widelands::Cmd_Queue::run_queue (this=0xbfffdc00, interval=605, game_time_var=@0xbfffdaac)

[Nicolai Hähnle (nha)]

Hopefully fixed in trunk revision 5008. (It's hard to reproduce and the fix necessarily causes the replay to go out of sync, so there may be a related problem that I haven't found)

[SirVer (sirver)]

Releasd in build15-rc1