record last_revision used to determine partial success before doing import
Bug #532402 reported by
Michael Hudson-Doyle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Michael Hudson-Doyle |
Bug Description
To determine whether a code import got all the revisions in a branch or stopped early because of a revision limit, we do roughly this:
doImport(source, target)
partial = target.
However, if the import takes several hours, as it does sometimes, it's moderately likely that the last_revision of the source has now changed, which will give rise to an (essentially) spurious result of partially successful.
Cheers,
mwh
Related branches
lp:~mwhudson/launchpad/fewer-spurious-partial-code-imports-bug-532402
Merged
into
lp:launchpad
- Tim Penhey (community): Approve
-
Diff: 18 lines (+2/-1)1 file modifiedlib/lp/codehosting/codeimport/worker.py (+2/-1)
Changed in launchpad-code: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10529 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 10529>