bugs with patches shows fix released bugs as well

[Micah Gersten]

For Firefox bugs in Ubuntu, the patches link shows Fix Released bugs with patches as well.

https://bugs.edge.launchpad.net/ubuntu/+source/firefox/+patches

This seems inconsistent with hiding Fix Released bugs by default.

[Deryck Hodge (deryck)]

Yeah, this is inconsistent, but it was believed (through discussions with stakeholders about the feature) that showing fixed bugs would help upstreams find patches they might not know about it.

Jorge and I discussed this on IRC today, too.

I'm not convinced showing fixed bugs makes sense.

Jorge, Karl, Abel, et al, can we use this bug to discuss whether or not this works out as planned, and then we can triage this bug?

Cheers,
deryck

[Jonathan Lange (jml)]

The way for upstream stakeholders to find fixes they might not know about is for the bugs with these patches to be marked as affecting the upstreams.

As an example, https://bugs.edge.launchpad.net/launchpad-foundations/+patches is less useful than it would be if "Fix released" bugs were hidden. Were they hidden, there'd be six bugs that foundations should consider fixing *right now*. As it is, a foundations hacker would have to manually filter out the eighteen completely uninteresting bugs with patches. There are work-arounds (sorting by status, for example), but why should a convenience feature need workarounds to be convenient to use?

Am happy to talk further about this. I think the work on the patch view has been great and am keen to see it polished off and crossed off our lists for good.

[Deryck Hodge (deryck)]

Agreed. I see no compelling reason to leave fixed bugs in. We should fix this now.

[Karl Fogel (kfogel)]

I find jml's arguments in comment #2 pretty convincing (and would like to subscribe to his newsletter).

However, just to explore the options: what if the default sort were by status first (and patch age second)? Then those six bugs would be on top anyway...

[Jonathan Lange (jml)]

On Mon, Mar 8, 2010 at 2:37 PM, Karl Fogel <email address hidden> wrote:
> However, just to explore the options: what if the default sort were by
> status first (and patch age second)?  Then those six bugs would be on
> top anyway...

That would be better than now. Why would it be preferable to hiding
fix released bugs altogether?

jml

[Karl Fogel (kfogel)]

Jono Lange and I just talked about this some more, and observed that it's bad that the list of patches will grow without band (if we show Fix Released patches) and the "N" in "N bugs with patches" in the bugfilters portlet will never go down. That tips me toward agreeing that we shouldn't show bugtasks whose status is Fix Released, and that the right way to forward patches upstream is to make a new bugtask against the upstream project.

Pinging jcastro for thoughts before making the change, though.

[Jorge Castro (jorge)]

I think it should hide them by default.

In the context of having people going through a list of patches the fixed bugs just clutter the UI. I think it would be better instead to encourage/enforce upstreaming bugs as part of the sponsorship/review process like we always do.

I think this should be revisited when we have a method to track a patch better throughout it's lifecycle. For example if an upstream bugtracker has our plugin and we have some method of making sending a patch upstream more integrated perhaps that would be a good time to revisit tracking a patch's status?

[Karl Fogel (kfogel)]

*nod* Yes. Thanks, Jorge.

[Ursula Junque (ursinha)]

Fixed in stable r10511 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10511>

[Karl Fogel (kfogel)]

QA'd by doing a search [1] for bugs with patches in Fix Released state first: there were 30 of them, including Critical bug
#312291. Then I looked at https://bugs.edge.launchpad.net/gwibber/+patches -- bug #312291 was nowhere to be found, and indeed there were no Fix Released bugs at all.

[1] https://bugs.edge.launchpad.net/gwibber/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=FIXRELEASED&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.tag=&field.tags_combinator=ANY&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_patch=on&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on