Advanced search allows checking contradictory options for linked branches

[Jonathan Lange]

The advanced search page has checkboxes for the following two options:

  Show only bugs with linked branches
  Show only bugs without linked branches

The "only" makes these instructions mutually contradictory. By default, both of these are checked at the same time.

[Eleanor Berger (intellectronica)]

On 3 March 2010 13:14, Jonathan Lange <email address hidden> wrote:
> Public bug reported:
>
> The advanced search page has checkboxes for the following two options:
>
>  Show only bugs with linked branches
>  Show only bugs without linked branches
>
> The "only" makes these instructions mutually contradictory. By default,
> both of these are checked at the same time.

I think a nice solution would be to add some Javascript magic that
only allows one or neither option to be toggled.

[Deryck Hodge (deryck)]

I think Jono is saying it's the "only" that is the problem.

You actually need both to get the default search results, which makes sense if you think about it. Bug lists have both bugs with branches and bugs without branches. Perhaps this could be better, I'll admit, but I think it's nice compared to the other options presented during review/UI review.

[Karl Fogel (kfogel)]

Yes, the fix is just to remove the word "only" from the options.

Branch coming up...

[Karl Fogel (kfogel)]

Note: in discussion with intellectronica and deryck, we agreed that a slightly better fix (UI-wise) would be to keep the word "only" but make the two options mutually exclusive -- add JavaScript to ensure they can't both be checked, or that one unchecks whenever the other one is checked.

However, that would be a much higher-overhead change. Cost/benefit analysis leads us to still prefer the simpler solution (just remove the word "only"). If someday we spend a cycle improving Advanced Search, we can do the other solution.

[Ursula Junque (ursinha)]

Fixed in stable r10471 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10471>