Move ISeriesMixin to lp.registry.interfaces.series
Bug #531261 reported by
Adi Roiban
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Adi Roiban |
Bug Description
Right now ISeriesMixin is located in lp.registry.
Since this Mixin should be used for DistroSeries and ProductSeries common attributes, we should move it to lp.registry.
We can also see what other attributes can be moved to ISeriesMixin
Related branches
lp:~adiroiban/launchpad/bug-531261
Merged
into
lp:launchpad
- Guilherme Salgado (community): Approve
-
Diff: 595 lines (+150/-152)8 files modifiedlib/lp/registry/interfaces/distroseries.py (+11/-39)
lib/lp/registry/interfaces/productseries.py (+6/-41)
lib/lp/registry/interfaces/series.py (+53/-1)
lib/lp/registry/model/distroseries.py (+4/-38)
lib/lp/registry/model/productseries.py (+7/-26)
lib/lp/registry/model/series.py (+53/-0)
lib/lp/registry/stories/webservice/xx-distroseries.txt (+1/-0)
lib/lp/registry/stories/webservice/xx-project-registry.txt (+15/-7)
Changed in launchpad-registry: | |
assignee: | nobody → Adi Roiban (adiroiban) |
Changed in launchpad-registry: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: tech-debt |
Changed in launchpad-registry: | |
status: | Triaged → In Progress |
tags: | added: iseries |
tags: |
added: qa-ok removed: qa-needstesting |
To post a comment you must log in.
Here is the list of attributes found both in IProductSeries and IDistroSeries.
Is it ok if I move them in ISeriesMixin and their implementation in SeriesMixin ?
Otherwise, are you happy with the changes from the current attached branch?
name = exported(
DistroSeriesNa meField(
title= _("Name" ), required=True,
descriptio n=_("The name of this series."),
constraint =name_validator ))
status = exported(
title= _("Status" ), required=True,
vocabulary =SeriesStatus) )
Choice(
date_created = exported(
Datetime( title=_ ("The date this series was registered.")))
owner = exported(
PublicPersonCh oice(title= _("Owner" ), vocabulary= 'ValidOwner' ))
driver = exported(
title= _("Driver" ),
descriptio n=_(
"The person or team responsible for decisions about features "
"and bugs that will be targeted to this series of the "
"distribution ."),
required= False, vocabulary= 'ValidPersonOrT eam'))
Choice(
title = exported(
title= _("Title" ), required=True,
descriptio n=_(
"The title of this series. It should be distinctive "
"and designed to look good at the top of a page.")))
Title(
displayname = exported(
title= _('Display Name'),
descriptio n=_('Display name, in this case we have removed the '
'underlyin g database field, and this attribute '
'just returns the name.')),
exported_ as='display_ name')
TextLine(
summary = exported(
Summary( title=_ ("Summary" ), required=True,
descriptio n=_(
"A brief summary of the highlights of this release. "
"It should be no longer than a single paragraph, up "
"to 200 words.")))
------- ------- ------- ------- ------- ------- ------- ------- ------- ------- ------- ------
The following attributes, have the same interface, but their implementation is different as they depend of product or distribution. Maybe we can move them in IHasBugs, IHasDrivers ... etc
packagings = Attribute("All of the Packaging entries for this "
"distroseries. ")
specifications = Attribute("The specifications targeted to this "
"series.")
drivers = Attribute(
'DistroSeries, and the Distribution to which it belong.')
'A list of the people or teams who are drivers for this series. '
'This list is made up of any drivers or owners from this '
bug_supervisor = Attribute(
'Currently just a reference to the Distribution bug supervisor.')
security_ contact = Attribute(
'Currently just a reference to the Distribution security contact.')