game crashes/assertion failure

[Victor Pelt]

I was playing. then when attacking around an enemy's headquarter the game crashes. when i try to load the autosave it fails with an assertion failure

[Victor Pelt (victor-pelt)]

savegame that fails

[Timowi (timo-wingender)]

Crashes because of a flag on field with wrong owner. Probably because of a conquered building with not enough land.

Writing Flag Data ... widelands: /home/timo/widelands/widelands/src/map_io/widelands_map_flag_data_packet.cc:143: virtual void Widelands::Map_Flag_Data_Packet::Write(FileSystem&, Widelands::Editor_Game_Base&, Widelands::Map_Map_Object_Saver&): Assertion `field->get_owned_by() == flag->owner().player_number()' failed.

savegame was written with unofficial-bzr-trunk-4995

[Victor Pelt (victor-pelt)]

yep i was conquering the HQ, means we should check for some other option of conquering might give bad results

[Sigra (sigra)]

Duplicate of [https://sourceforge.net/tracker/?func=detail&aid=2927882&group_id=40163&atid=427221].

[Nicolai Hähnle (nha)]

Here's another savegame that fails with slightly different symptoms, but the underlying problem (incorrect assignment of field ownership) appears to be the same. Here's the error message we get:

flags: 2246 (at (27, 83), owned by player 1): neighbour node (27, 84): is owned by player 3

[Sigra (sigra)]

We do not need more savegames attached to this duplicate report of a well-understood bug. What we need is a rewrite of the map object loading code, making sure that it does not call any init() functions. (By the way, it is called *node* ownership, to be precise.)