Not modifying a suggested commit message commits anyway

[James Westby]

The ability to seed the commit message with text taken from elsewhere is useful, but
it interacts badly with the desire to cancel commits at that point.

Often when editing a commit message it makes me realise something is missing, and
so I want to cancel the commit.

Normally I can do this by exiting without saving, or saving and closing my editor without
writing anything.

However, when the commit has been seeded, neither of these works, the only way to do
it is to delete all the text in the file, then save that and exit. Doing anything else results in
the commit happening anyway, so I have to uncommit (and sometimes don't notice until later)

Jelmer's suggestion was to have bzr prompt if the commit message is unchanged from the
seeded one.

Thanks,

James

[Robert Collins (lifeless)]

On Mon, 2010-03-01 at 19:50 +0000, James Westby wrote:

> Normally I can do this by exiting without saving, or saving and closing my editor without
> writing anything.
>
> However, when the commit has been seeded, neither of these works, the only way to do
> it is to delete all the text in the file, then save that and exit. Doing anything else results in
> the commit happening anyway, so I have to uncommit (and sometimes don't notice until later)
>
> Jelmer's suggestion was to have bzr prompt if the commit message is unchanged from the
> seeded one.

That won't work well if bzr can't prompt (it can run EDITOR under e.g. X
even if bzr has no stdin).

Perhaps having a line
**** DELETE THIS LINE to use the suggested commit message ****

?

-Rob

[Robert Collins (lifeless)]

Sorry, that branch appears to have done something totally different. ENOIDEAWHY.