bzr branch fails to set parent
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
John A Meinel |
Bug Description
After my changes to make the contents of '.bzr/branch/
Where when I try to branch someone else's branch, their parent may not be accessible to me.
But 'bzr branch' uses 'sprout', which uses 'copy_content_into' which defaults to copying the parent over.
The old code would just get an absolute or relative but unaccessible path back. The new code tries to change the relative path into an absolute path, which can be nice if the creator used sftp to create the branch, but you are accessing it over http.
However, if the old path was outside the url scheme, you get an 'InvalidURLJoin' exception. As a specific example, branching:
http://
has a parent of: '../../
which obviously doesn't fit in the public url scheme.
I'll be writing up a simple fix which catches the exception, and just changes the parent to be None.
Related branches
Changed in bzr: | |
assignee: | nobody → jameinel |
status: | Unconfirmed → Fix Committed |
importance: | Untriaged → Medium |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
John A Meinel wrote: parent' be a
> Public bug reported:
>
> After my changes to make the contents of '.bzr/branch/
> relative path, we now have a new bug that shows up.
>
> Where when I try to branch someone else's branch, their parent may not be accessible to me.
> But 'bzr branch' uses 'sprout', which uses 'copy_content_into' which defaults to copying the parent over.
That doesn't seem like something sprout should do.
Aaron enigmail. mozdev. org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://
iD8DBQFEt7nY0F+ nu1YWqI0RAtnAAJ 0dL2rSzwLMhYpG3 Qyiq/01mZ9S4wCf bhQ/ oph8qPcs=
cJ9Sko7fMph5P8p
=IOrJ
-----END PGP SIGNATURE-----