Failure to check for existing dir
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Pluck CMS |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
in install.php you have:
//Make some dirs for the trashcan and modulesettings
mkdir('
chmod('
.....
So you are "assuming" the dir do not exist! Yet going "back" to the page in the browser issues warnings that the dir already does exist and the above code is trying to recreate them! Wrong and sloppy.
Warnings are there to tell you something about your code, often something that needs to be fixed. You seem to have warnings turned off so are missing these clues to better coding. You should have written it as:
if (!file_
mkdir(
chmod(
}
... etc for each dir.
Related branches
Changed in pluck-cms: | |
status: | New → Fix Committed |
Changed in pluck-cms: | |
milestone: | none → 4.7-beta |
status: | Fix Committed → Fix Released |