Time indicator not accurate

Bug #529238 reported by Arisian
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
FreeGuide-TV
Fix Released
Low
Unassigned

Bug Description

The arrow in the time bar doesn't follow current time very well. Occasionally switching from one program to another will cause the arrow to jump forward but not always.

Especially when clicking on "Go to now", the arrow is often offscreen, stuck at some previous time.

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Thanks for reporting this problem - yes, it should be fixed.

Changed in freeguide-tv:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Arisian (mmclagan) wrote :
Revision history for this message
Arisian (mmclagan) wrote :

This patch corrects two issues with the time marker.

1) When viewing any day other than "today", half the time marker is drawn at the far left side (start of day time) even though the current time is on a past or future date.

2) The marker is now moved every 60 seconds using a Swing Timer, therefore doesn't become out of sync with the system clock.

Revision history for this message
Arisian (mmclagan) wrote :

The first patch introduced a problem with the selected channel list. This patch, applied after the first, fixes that.

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

The attached patches seem to be doing a number of different things (apologies if I've misunderstood it):

- In ConfigureUIController, rename "parent" to "viewer"
- Moving ConfigureUIController's config object into the HorizontalViewer (and VerticalViewer) itself
- Removing the SimpleDateFormat members in TimePanel and using temporaries
- White space changes
- Changes to the way the TimePanel is painted
- Refreshing the TimePanel every minute (and removing the "display" boolean - are these connected?)

At the moment there are a lot of moving parts, and it makes it difficult for me to review the code.

If these elements could be split up and provided separately (or a different breakdown if I have misunderstood), with an explanation for each one, it would really help me review and commit them.

Thanks, Andy

Changed in freeguide-tv:
status: Confirmed → In Progress
Revision history for this message
Arisian (mmclagan) wrote :

The following patch implements *ONLY* a timer to update the TimePanel arrow.

Revision history for this message
Arisian (mmclagan) wrote :
Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

Thanks! I have committed a modified version of freeguide-0.10.12-timer.patch. Along with whitespace changes, I also modified to check 3 times every minute, instead of every second (and therefore to update every time.)

Revision history for this message
Andy Balaam (mail-artificialworlds) wrote :

I have committed the whitespace patch you attached too. Thanks for fixing this bug!

Changed in freeguide-tv:
status: In Progress → Fix Committed
Changed in freeguide-tv:
milestone: none → 0.11
Changed in freeguide-tv:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.