Button press events force xchat into text selection mode that can't be broken.

[Cody Russell]

Binary package hint: xchat-gnome

This is caused by the Lucid changes to gtk+, and is noticeable only if you have csd enabled.

[Cody Russell (bratsche)]

Found one more case that needed a change.

[Nigel Babu (nigelbabu)]

Thanks for your patch. Can you open a bug report upstream and submit the patch there too?

[Cody Russell (bratsche)]

Done: https://bugzilla.gnome.org/show_bug.cgi?id=613059

[Nigel Babu (nigelbabu)]

Thanks for submitting it upstream, could you address a few concerns? Will the proposed patch have correct behaviour when CSD is disabled too? Possible to check if CSD is enabled or disabled before returning True/False. Is CSD expected to be enabled in lucid by default. Once these concerns are addressed, I'll be happy to package and get it uploaded.

[Cody Russell (bratsche)]

It should not affect the operation in non-CSD mode at all.

This actually just seems to be a bug in xchat-gnome that has never been noticed because when the event propagates up to the toplevel widget there has never been one that catches it before.

It should return TRUE if it handles the button-press event.

But CSD will not be in Lucid, so keeping the bug in xchat-gnome isn't hurting anything at the moment. But it would still be nice to get it fixed in upstream. :)

[Nigel Babu (nigelbabu)]

Since CSD will not be in Lucid, we'll wait for upstream to integrate the patch then.

[Cody Russell (bratsche)]

This was accepted upstream and it will be in the next release. Since we don't need this now until Lucid+1 there's no need to keep tracking it in Launchpad I think.